Commit 2341548
Set merge option to true in WebpackAssetsManifest (#800)
When used with bin/shakapacker, merge must be true in all environments
to support users with multiple client configurations.
### Summary
<!--
Describe the code changes in your pull request here - were there any
bugs you had fixed, features you added, tradeoffs you made?
If so, mention them. If these changes have open GitHub issues, tag them
here as well to keep the conversation linked.
-->
### Pull Request checklist
<!-- If any of the items on this checklist do not apply to the PR, both
check it out and wrap it by `~`. -->
- [ ] Add/update test to cover these changes
- [ ] Update documentation
- [ ] Update CHANGELOG file
### Other Information
<!--
Mention any other important information that might relate to this PR but
that don't belong in the summary,
like detailed benchmarks or possible follow-up changes.
-->
<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit
* **Fixed**
* Manifest merging for multi-client builds now applies across all
environments, preventing duplicated or missing asset entries during
builds.
* **Chores**
* Updated asset manifest behavior to consistently merge manifests,
ensuring uniform asset bundling and predictable build outputs.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
---------
Co-authored-by: Justin Gordon <justin@shakacode.com>1 parent f7d1bd7 commit 2341548
2 files changed
Lines changed: 6 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
9 | 9 | | |
10 | 10 | | |
11 | 11 | | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
12 | 16 | | |
13 | 17 | | |
14 | 18 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
5 | 5 | | |
6 | 6 | | |
7 | 7 | | |
8 | | - | |
| 8 | + | |
9 | 9 | | |
10 | 10 | | |
11 | 11 | | |
| |||
17 | 17 | | |
18 | 18 | | |
19 | 19 | | |
20 | | - | |
| 20 | + | |
21 | 21 | | |
22 | 22 | | |
23 | 23 | | |
| |||
0 commit comments