Split: Add support for longer strings (#1042)

Author: som-sm

source/split.d.ts

@@ -22,8 +22,14 @@ array = split(items, ',');
 export type Split<
 	S extends string,
 	Delimiter extends string,
+> = SplitHelper<S, Delimiter>;
+
+type SplitHelper<
+	S extends string,
+	Delimiter extends string,
+	Accumulator extends string[] = [],
 > = S extends `${infer Head}${Delimiter}${infer Tail}`
-	? [Head, ...Split<Tail, Delimiter>]
-	: S extends Delimiter
-		? []
-		: [S];
+	? SplitHelper<Tail, Delimiter, [...Accumulator, Head]>
+	: Delimiter extends ''
+		? Accumulator
+		: [...Accumulator, S];

test-d/split.ts

@@ -1,5 +1,6 @@
 import {expectType} from 'tsd';
 import type {Split} from '../index';
+import type {BuildTuple} from '../source/internal';
 
 declare function split<
 	S extends string,
@@ -28,3 +29,11 @@ expectType<[]>(split('', ''));
 
 // Split empty string by any string.
 expectType<['']>(split('', ' '));
+
+// Recursion depth at which a non-tail recursive implementation starts to fail.
+const fiftyZeroes = '00000000000000000000000000000000000000000000000000';
+expectType<BuildTuple<50, '0'>>(split(fiftyZeroes, ''));
+
+// Maximum allowed recursion depth for a tail recursive implementation.
+const nineHundredNinetyNineZeroes = '000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000';
+expectType<BuildTuple<999, '0'>>(split(nineHundredNinetyNineZeroes, ''));