Skip to content

Commit 6f878b3

Browse files
silverdevJesseLovelace
authored andcommitted
Added explicit decencies for surefile-junit4 in order to fix testing in offline mode. (googleapis#3820)
* Added explicit sunfire-junit depency to pull it in for offline mode. Without this dependency explicitly listed java mvn dependency:go-offline will not pull it in and mvn -o verify will not work (Unless the tests have been run in online mode. In this case the cached surefire junit can still be used.) * Adding Surefire depency to bigtable admin and logging as well. * Looks like I need to tell the plugin that it's using the version I'm pulling in. * Looks like the Google Cloud Java Compatibility Checker test require surefire version 2.17 [INFO] Building Google Cloud Java Compatibility Checker 0.67.1-alpha-SNAPSHOT [INFO] ------------------------------------------------------------------------ [WARNING] The POM for org.apache.maven.plugins:maven-surefire-plugin:jar:2.17 is missing, no dependency information available * dependecies is not under build. * Some of the GRPC library need dependencies need surefire 2.17 [INFO] ------------------------------------------------------------------------ [INFO] Building Google Cloud API gRPC 0.32.1-SNAPSHOT [INFO] ------------------------------------------------------------------------ [INFO] [INFO] ------------------------------------------------------------------------ [INFO] Building proto-google-cloud-asset-v1beta1 0.32.1-SNAPSHOT [INFO] ------------------------------------------------------------------------ [WARNING] The POM for org.apache.maven.plugins:maven-surefire-plugin:jar:2.17 is missing, no dependency information available [INFO] [INFO] ------------------------------------------------------------------------ [INFO] Skipping grpc-google-cloud-asset-v1beta1 [INFO] This project has been banned from the build due to previous failures. [INFO] ------------------------------------------------------------------------ [INFO] [INFO] ------------------------------------------------------------------------ [INFO] Building proto-google-cloud-automl-v1beta1 0.32.1-SNAPSHOT [INFO] ------------------------------------------------------------------------ [WARNING] The POM for org.apache.maven.plugins:maven-surefire-plugin:jar:2.17 is missing, no dependency information available [INFO] [INFO] ------------------------------------------------------------------------ [INFO] Skipping grpc-google-cloud-automl-v1beta1 [INFO] This project has been banned from the build due to previous failures. [INFO] ------------------------------------------------------------------------ * Looks like the file path is org.apache.maven.plugins * lets try putting the in utils. It looks like utill uses surefire 2.17 * Looks like spanner uses surefire-junit47 instead of surefire-junit4 * Re-add bigtable admin version * Lets not include spanner with this PR.
1 parent 274a58f commit 6f878b3

1 file changed

Lines changed: 5 additions & 0 deletions

File tree

  • java-logging/google-cloud-logging

java-logging/google-cloud-logging/pom.xml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -88,5 +88,10 @@
8888
<classifier>testlib</classifier>
8989
<scope>test</scope>
9090
</dependency>
91+
<dependency>
92+
<groupId>org.apache.maven.surefire</groupId>
93+
<artifactId>surefire-junit4</artifactId>
94+
<version>2.19.1</version>
95+
</dependency>
9196
</dependencies>
9297
</project>

0 commit comments

Comments
 (0)