Skip to content

Commit 0744300

Browse files
committed
Remove hello/hello_standalone_activity.py in favor of top-level hello_standalone_activity/ sample
The standalone activity sample now lives in its own top-level directory (added by Phil in fc08204). Update the test to import from the new location and update both READMEs accordingly.
1 parent ec9ead2 commit 0744300

4 files changed

Lines changed: 6 additions & 86 deletions

File tree

README.md

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -55,8 +55,6 @@ Some examples require extra dependencies. See each sample's directory for specif
5555
* [hello_search_attributes](hello/hello_search_attributes.py) - Start workflow with search attributes then change
5656
while running.
5757
* [hello_signal](hello/hello_signal.py) - Send signals to a workflow.
58-
* [hello standalone activity](hello/hello_standalone_activity.py) - Execute an activity from outside of a workflow.
59-
* Note: Standalone activities is supported in CLI version [v1.6.2](https://github.com/temporalio/cli/releases/tag/v1.6.2-standalone-activity).
6058
* [hello update](hello/hello_update.py) - Send a request to and a response from a client to a workflow execution.
6159
<!-- Keep this list in alphabetical order -->
6260
* [activity_worker](activity_worker) - Use Python activities from a workflow in another language.
@@ -72,6 +70,7 @@ Some examples require extra dependencies. See each sample's directory for specif
7270
* [encryption](encryption) - Apply end-to-end encryption for all input/output.
7371
* [env_config](env_config) - Load client configuration from TOML files with programmatic overrides.
7472
* [gevent_async](gevent_async) - Combine gevent and Temporal.
73+
* [hello_standalone_activity](hello_standalone_activity) - Use activities without using a workflow.
7574
* [langchain](langchain) - Orchestrate workflows for LangChain.
7675
* [message_passing/introduction](message_passing/introduction/) - Introduction to queries, signals, and updates.
7776
* [message_passing/safe_message_handlers](message_passing/safe_message_handlers/) - Safely handling updates and signals.
@@ -87,7 +86,7 @@ Some examples require extra dependencies. See each sample's directory for specif
8786
* [updatable_timer](updatable_timer) - A timer that can be updated while sleeping.
8887
* [worker_specific_task_queues](worker_specific_task_queues) - Use unique task queues to ensure activities run on specific workers.
8988
* [worker_versioning](worker_versioning) - Use the Worker Versioning feature to more easily version your workflows & other code.
90-
* [worker_multiprocessing](worker_multiprocessing) - Leverage Python multiprocessing to parallelize workflow tasks and other CPU bound operations by running multiple workers.
89+
* [worker_multiprocessing](worker_multiprocessing) - Leverage Python multiprocessing to parallelize workflow tasks and other CPU bound operations by running multiple workers.
9190

9291
## Test
9392

hello/README.md

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -44,8 +44,6 @@ Replace `hello/hello_activity.py` in the command with any other example filename
4444
* [hello_search_attributes](hello_search_attributes.py) - Start workflow with search attributes then change while
4545
running.
4646
* [hello_signal](hello_signal.py) - Send signals to a workflow.
47-
* [hello standalone activity](hello_standalone_activity.py) - Execute an activity from outside of a workflow.
48-
* Note: Standalone activities is supported in CLI version [v1.6.2](https://github.com/temporalio/cli/releases/tag/v1.6.2-standalone-activity).
4947
* [hello_update](hello_update.py) - **Send a request to and a response from a client to a workflow execution.**
5048

5149
Note: To enable the workflow update, set the `frontend.enableUpdateWorkflowExecution` dynamic config value to true.

hello/hello_standalone_activity.py

Lines changed: 0 additions & 79 deletions
This file was deleted.

tests/hello/hello_standalone_activity_test.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,11 +6,13 @@
66
from temporalio.client import Client
77
from temporalio.worker import Worker
88

9-
from hello.hello_standalone_activity import ComposeGreetingInput, compose_greeting
9+
from hello_standalone_activity.my_activity import ComposeGreetingInput, compose_greeting
1010

1111

1212
async def test_execute_standalone_activity(client: Client):
13-
pytest.skip("Standalone Activity is not yet supported by the CLI dev server")
13+
pytest.skip(
14+
"Standalone Activity is not yet supported by `temporal server start-dev`"
15+
)
1416
task_queue_name = str(uuid.uuid4())
1517

1618
async with Worker(

0 commit comments

Comments
 (0)