fix: ignore waitForElementToBeRemoved callbacks

Author: JMiltier

docs/rules/no-unsettled-absence-query.md

@@ -12,7 +12,7 @@ This rule fires when an absence assertion on a `queryBy*` / `queryAllBy*` query
 
 **What counts as "settled":**
 
-1. Any `await` expression on a preceding statement - covers `findBy*`, `waitFor`, `act`, or custom async helpers.
+1. Any `await` expression on a preceding statement - covers `findBy*`, `waitFor`, `waitForElementToBeRemoved`, `act`, or custom async helpers.
 2. A `getBy*` / `getAllBy*` call on a preceding statement - proves the synchronous render produced expected output.
 
 **Additionally**, absence assertions inside a `waitFor` callback are always flagged, because `waitFor` retries until the assertion passes - an absence check passes on the first invocation before the component has settled.
@@ -77,6 +77,13 @@ test('shows no error', () => {
 	screen.getByText('visible heading');
 	expect(screen.queryByText('error')).not.toBeInTheDocument();
 });
+
+// waitForElementToBeRemoved is a settling expression on its own
+test('shows no error', async () => {
+	render(<Component />);
+	await waitForElementToBeRemoved(() => screen.queryByText('loading'));
+	expect(screen.queryByText('error')).not.toBeInTheDocument();
+});
 ```
 
 ## Further Reading

src/rules/no-unsettled-absence-query.ts

@@ -106,7 +106,7 @@ export default createTestingLibraryRule<Options, MessageIds>({
 			);
 		}
 
-		function isInsideAsyncUtilCallback(node: TSESTree.Node): boolean {
+		function isInsideWaitForCallback(node: TSESTree.Node): boolean {
 			let current: TSESTree.Node | undefined = node.parent;
 
 			while (current) {
@@ -118,7 +118,10 @@ export default createTestingLibraryRule<Options, MessageIds>({
 					const calleeIdentifier = getDeepestIdentifierNode(
 						current.parent.callee
 					);
-					if (calleeIdentifier && helpers.isAsyncUtil(calleeIdentifier)) {
+					if (
+						calleeIdentifier &&
+						helpers.isAsyncUtil(calleeIdentifier, ['waitFor'])
+					) {
 						return true;
 					}
 				}
@@ -188,7 +191,7 @@ export default createTestingLibraryRule<Options, MessageIds>({
 					return;
 				}
 
-				if (isInsideAsyncUtilCallback(node)) {
+				if (isInsideWaitForCallback(node)) {
 					context.report({
 						node,
 						messageId: 'noUnsettledAbsenceQuery',

tests/rules/no-unsettled-absence-query.test.ts

@@ -62,6 +62,18 @@ ruleTester.run('no-unsettled-absence-query', rule, {
 			`,
 		},
 
+		{
+			code: `
+			import { render, screen, waitForElementToBeRemoved } from '@testing-library/react'
+
+			test('waitForElementToBeRemoved is itself a settling expression', async () => {
+				render(<Component />)
+				await waitForElementToBeRemoved(() => screen.queryByText('loading'))
+				expect(screen.queryByText('error')).not.toBeInTheDocument()
+			})
+			`,
+		},
+
 		{
 			code: `
 			import { render, screen } from '@testing-library/react'