Fix overflow when calculating max allowed size of memory (4Gb)

gumb0 · gumb0 · commit 20cb1a0a1a96 · 2022-01-10T17:43:49.000+01:00
diff --git a/lib/fizzy/limits.hpp b/lib/fizzy/limits.hpp
@@ -14,7 +14,7 @@ constexpr uint32_t PageSize = 65536;
 /// Convert memory size in pages to size in bytes.
 inline constexpr uint64_t memory_pages_to_bytes(uint32_t pages) noexcept
 {
-    return pages * PageSize;
+    return uint64_t{pages} * PageSize;
 }
 
 /// The maximum memory page limit as defined by the specification.

Original file line number	Diff line number	Diff line change
`@@ -14,7 +14,7 @@ constexpr uint32_t PageSize = 65536;`
`14`	`14`	`/// Convert memory size in pages to size in bytes.`
`15`	`15`	`inline constexpr uint64_t memory_pages_to_bytes(uint32_t pages) noexcept`
`16`	`16`	`{`
`17`		`- return pages * PageSize;`
	`17`	`+ return uint64_t{pages} * PageSize;`
`18`	`18`	`}`
`19`	`19`
`20`	`20`	`/// The maximum memory page limit as defined by the specification.`