Skip to content

Commit 7308462

Browse files
committed
Fix tests to not pollute upper bits
1 parent bfb9c97 commit 7308462

1 file changed

Lines changed: 15 additions & 19 deletions

File tree

test/unittests/execute_numeric_test.cpp

Lines changed: 15 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -84,8 +84,8 @@ TEST(execute_numeric, i32_lt_s)
8484
{
8585
EXPECT_THAT(execute_binary_operation(Instr::i32_lt_s, 22, 20), Result(0));
8686
EXPECT_THAT(execute_binary_operation(Instr::i32_lt_s, 20, 22), Result(1));
87-
// EXPECT_THAT(execute_binary_operation(Instr::i32_lt_s, uint64_t(-41), uint64_t(-42)), Result(0));
88-
// EXPECT_THAT(execute_binary_operation(Instr::i32_lt_s, uint64_t(-42), uint64_t(-41)), Result(1));
87+
EXPECT_THAT(execute_binary_operation(Instr::i32_lt_s, uint32_t(-41), uint32_t(-42)), Result(0));
88+
EXPECT_THAT(execute_binary_operation(Instr::i32_lt_s, uint32_t(-42), uint32_t(-41)), Result(1));
8989
}
9090

9191
TEST(execute_numeric, i32_lt_u)
@@ -98,8 +98,8 @@ TEST(execute_numeric, i32_gt_s)
9898
{
9999
EXPECT_THAT(execute_binary_operation(Instr::i32_gt_s, 22, 20), Result(1));
100100
EXPECT_THAT(execute_binary_operation(Instr::i32_gt_s, 20, 22), Result(0));
101-
// EXPECT_THAT(execute_binary_operation(Instr::i32_gt_s, uint64_t(-41), uint64_t(-42)), Result(1));
102-
// EXPECT_THAT(execute_binary_operation(Instr::i32_gt_s, uint64_t(-42), uint64_t(-41)), Result(0));
101+
EXPECT_THAT(execute_binary_operation(Instr::i32_gt_s, uint32_t(-41), uint32_t(-42)), Result(1));
102+
EXPECT_THAT(execute_binary_operation(Instr::i32_gt_s, uint32_t(-42), uint32_t(-41)), Result(0));
103103
}
104104

105105
TEST(execute_numeric, i32_gt_u)
@@ -113,9 +113,9 @@ TEST(execute_numeric, i32_le_s)
113113
EXPECT_THAT(execute_binary_operation(Instr::i32_le_s, 22, 20), Result(0));
114114
EXPECT_THAT(execute_binary_operation(Instr::i32_le_s, 20, 22), Result(1));
115115
EXPECT_THAT(execute_binary_operation(Instr::i32_le_s, 20, 20), Result(1));
116-
// EXPECT_THAT(execute_binary_operation(Instr::i32_le_s, uint64_t(-41), uint64_t(-42)), Result(0));
117-
// EXPECT_THAT(execute_binary_operation(Instr::i32_le_s, uint64_t(-42), uint64_t(-41)), Result(1));
118-
// EXPECT_THAT(execute_binary_operation(Instr::i32_le_s, uint64_t(-42), uint64_t(-42)), Result(1));
116+
EXPECT_THAT(execute_binary_operation(Instr::i32_le_s, uint32_t(-41), uint32_t(-42)), Result(0));
117+
EXPECT_THAT(execute_binary_operation(Instr::i32_le_s, uint32_t(-42), uint32_t(-41)), Result(1));
118+
EXPECT_THAT(execute_binary_operation(Instr::i32_le_s, uint32_t(-42), uint32_t(-42)), Result(1));
119119
}
120120

121121
TEST(execute_numeric, i32_le_u)
@@ -130,9 +130,9 @@ TEST(execute_numeric, i32_ge_s)
130130
EXPECT_THAT(execute_binary_operation(Instr::i32_ge_s, 22, 20), Result(1));
131131
EXPECT_THAT(execute_binary_operation(Instr::i32_ge_s, 20, 22), Result(0));
132132
EXPECT_THAT(execute_binary_operation(Instr::i32_ge_s, 20, 20), Result(1));
133-
// EXPECT_THAT(execute_binary_operation(Instr::i32_ge_s, uint64_t(-41), uint64_t(-42)), Result(1));
134-
// EXPECT_THAT(execute_binary_operation(Instr::i32_ge_s, uint64_t(-42), uint64_t(-41)), Result(0));
135-
// EXPECT_THAT(execute_binary_operation(Instr::i32_ge_s, uint64_t(-42), uint64_t(-42)), Result(1));
133+
EXPECT_THAT(execute_binary_operation(Instr::i32_ge_s, uint32_t(-41), uint32_t(-42)), Result(1));
134+
EXPECT_THAT(execute_binary_operation(Instr::i32_ge_s, uint32_t(-42), uint32_t(-41)), Result(0));
135+
EXPECT_THAT(execute_binary_operation(Instr::i32_ge_s, uint32_t(-42), uint32_t(-42)), Result(1));
136136
}
137137

138138
TEST(execute_numeric, i32_ge_u)
@@ -268,7 +268,6 @@ TEST(execute_numeric, i32_mul)
268268
TEST(execute_numeric, i32_div_s)
269269
{
270270
EXPECT_THAT(execute_binary_operation(Instr::i32_div_s, uint32_t(-84), 2), Result(-42));
271-
// EXPECT_THAT(execute_binary_operation(Instr::i32_div_s, uint64_t(-84), 2), Result(-42));
272271
}
273272

274273
TEST(execute_numeric, i32_div_s_by_zero)
@@ -278,9 +277,6 @@ TEST(execute_numeric, i32_div_s_by_zero)
278277

279278
TEST(execute_numeric, i32_div_s_overflow)
280279
{
281-
// EXPECT_THAT(execute_binary_operation(
282-
// Instr::i32_div_s, uint64_t(std::numeric_limits<int32_t>::min()), uint64_t(-1)),
283-
// Traps());
284280
EXPECT_THAT(execute_binary_operation(
285281
Instr::i32_div_s, uint32_t(std::numeric_limits<int32_t>::min()), uint32_t(-1)),
286282
Traps());
@@ -311,10 +307,10 @@ TEST(execute_numeric, i32_div_u_by_zero)
311307

312308
TEST(execute_numeric, i32_rem_s)
313309
{
314-
// EXPECT_THAT(execute_binary_operation(Instr::i32_rem_s, uint64_t(-4242), 4200), Result(-42));
315-
// constexpr auto i32_min = std::numeric_limits<int32_t>::min();
316-
// EXPECT_THAT(
317-
// execute_binary_operation(Instr::i32_rem_s, uint64_t(i32_min), uint64_t(-1)), Result(0));
310+
// EXPECT_THAT(execute_binary_operation(Instr::i32_rem_s, uint64_t(-4242), 4200),
311+
// Result(-42)); constexpr auto i32_min = std::numeric_limits<int32_t>::min(); EXPECT_THAT(
312+
// execute_binary_operation(Instr::i32_rem_s, uint64_t(i32_min), uint64_t(-1)),
313+
// Result(0));
318314
EXPECT_THAT(execute_binary_operation(Instr::i32_rem_s, uint32_t(-4242), 4200), Result(-42));
319315
constexpr auto i32_min = std::numeric_limits<int32_t>::min();
320316
EXPECT_THAT(
@@ -377,7 +373,7 @@ TEST(execute_numeric, i32_shl)
377373

378374
TEST(execute_numeric, i32_shr_s)
379375
{
380-
// EXPECT_THAT(execute_binary_operation(Instr::i32_shr_s, uint64_t(-84), 1), Result(-42));
376+
EXPECT_THAT(execute_binary_operation(Instr::i32_shr_s, uint32_t(-84), 1), Result(-42));
381377
EXPECT_THAT(execute_binary_operation(Instr::i32_shr_s, 0xffffffff, 0), Result(0xffffffff));
382378
EXPECT_THAT(execute_binary_operation(Instr::i32_shr_s, 0xffffffff, 1), Result(0xffffffff));
383379
EXPECT_THAT(execute_binary_operation(Instr::i32_shr_s, 0xffffffff, 31), Result(0xffffffff));

0 commit comments

Comments
 (0)