Skip to content

Commit d5b35f5

Browse files
committed
Fix tests to not pollute upper bits
1 parent cd9319c commit d5b35f5

1 file changed

Lines changed: 11 additions & 15 deletions

File tree

test/unittests/execute_numeric_test.cpp

Lines changed: 11 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -86,8 +86,8 @@ TEST(execute_numeric, i32_lt_s)
8686
{
8787
EXPECT_THAT(execute_binary_operation(Instr::i32_lt_s, 22, 20), Result(0));
8888
EXPECT_THAT(execute_binary_operation(Instr::i32_lt_s, 20, 22), Result(1));
89-
// EXPECT_THAT(execute_binary_operation(Instr::i32_lt_s, uint64_t(-41), uint64_t(-42)), Result(0));
90-
// EXPECT_THAT(execute_binary_operation(Instr::i32_lt_s, uint64_t(-42), uint64_t(-41)), Result(1));
89+
EXPECT_THAT(execute_binary_operation(Instr::i32_lt_s, uint32_t(-41), uint32_t(-42)), Result(0));
90+
EXPECT_THAT(execute_binary_operation(Instr::i32_lt_s, uint32_t(-42), uint32_t(-41)), Result(1));
9191
}
9292

9393
TEST(execute_numeric, i32_lt_u)
@@ -100,8 +100,8 @@ TEST(execute_numeric, i32_gt_s)
100100
{
101101
EXPECT_THAT(execute_binary_operation(Instr::i32_gt_s, 22, 20), Result(1));
102102
EXPECT_THAT(execute_binary_operation(Instr::i32_gt_s, 20, 22), Result(0));
103-
// EXPECT_THAT(execute_binary_operation(Instr::i32_gt_s, uint64_t(-41), uint64_t(-42)), Result(1));
104-
// EXPECT_THAT(execute_binary_operation(Instr::i32_gt_s, uint64_t(-42), uint64_t(-41)), Result(0));
103+
EXPECT_THAT(execute_binary_operation(Instr::i32_gt_s, uint32_t(-41), uint32_t(-42)), Result(1));
104+
EXPECT_THAT(execute_binary_operation(Instr::i32_gt_s, uint32_t(-42), uint32_t(-41)), Result(0));
105105
}
106106

107107
TEST(execute_numeric, i32_gt_u)
@@ -115,9 +115,9 @@ TEST(execute_numeric, i32_le_s)
115115
EXPECT_THAT(execute_binary_operation(Instr::i32_le_s, 22, 20), Result(0));
116116
EXPECT_THAT(execute_binary_operation(Instr::i32_le_s, 20, 22), Result(1));
117117
EXPECT_THAT(execute_binary_operation(Instr::i32_le_s, 20, 20), Result(1));
118-
// EXPECT_THAT(execute_binary_operation(Instr::i32_le_s, uint64_t(-41), uint64_t(-42)), Result(0));
119-
// EXPECT_THAT(execute_binary_operation(Instr::i32_le_s, uint64_t(-42), uint64_t(-41)), Result(1));
120-
// EXPECT_THAT(execute_binary_operation(Instr::i32_le_s, uint64_t(-42), uint64_t(-42)), Result(1));
118+
EXPECT_THAT(execute_binary_operation(Instr::i32_le_s, uint32_t(-41), uint32_t(-42)), Result(0));
119+
EXPECT_THAT(execute_binary_operation(Instr::i32_le_s, uint32_t(-42), uint32_t(-41)), Result(1));
120+
EXPECT_THAT(execute_binary_operation(Instr::i32_le_s, uint32_t(-42), uint32_t(-42)), Result(1));
121121
}
122122

123123
TEST(execute_numeric, i32_le_u)
@@ -132,9 +132,9 @@ TEST(execute_numeric, i32_ge_s)
132132
EXPECT_THAT(execute_binary_operation(Instr::i32_ge_s, 22, 20), Result(1));
133133
EXPECT_THAT(execute_binary_operation(Instr::i32_ge_s, 20, 22), Result(0));
134134
EXPECT_THAT(execute_binary_operation(Instr::i32_ge_s, 20, 20), Result(1));
135-
// EXPECT_THAT(execute_binary_operation(Instr::i32_ge_s, uint64_t(-41), uint64_t(-42)), Result(1));
136-
// EXPECT_THAT(execute_binary_operation(Instr::i32_ge_s, uint64_t(-42), uint64_t(-41)), Result(0));
137-
// EXPECT_THAT(execute_binary_operation(Instr::i32_ge_s, uint64_t(-42), uint64_t(-42)), Result(1));
135+
EXPECT_THAT(execute_binary_operation(Instr::i32_ge_s, uint32_t(-41), uint32_t(-42)), Result(1));
136+
EXPECT_THAT(execute_binary_operation(Instr::i32_ge_s, uint32_t(-42), uint32_t(-41)), Result(0));
137+
EXPECT_THAT(execute_binary_operation(Instr::i32_ge_s, uint32_t(-42), uint32_t(-42)), Result(1));
138138
}
139139

140140
TEST(execute_numeric, i32_ge_u)
@@ -270,7 +270,6 @@ TEST(execute_numeric, i32_mul)
270270
TEST(execute_numeric, i32_div_s)
271271
{
272272
EXPECT_THAT(execute_binary_operation(Instr::i32_div_s, uint32_t(-84), 2), Result(-42));
273-
// EXPECT_THAT(execute_binary_operation(Instr::i32_div_s, uint64_t(-84), 2), Result(-42));
274273
}
275274

276275
TEST(execute_numeric, i32_div_s_by_zero)
@@ -280,9 +279,6 @@ TEST(execute_numeric, i32_div_s_by_zero)
280279

281280
TEST(execute_numeric, i32_div_s_overflow)
282281
{
283-
// EXPECT_THAT(execute_binary_operation(
284-
// Instr::i32_div_s, uint64_t(std::numeric_limits<int32_t>::min()), uint64_t(-1)),
285-
// Traps());
286282
EXPECT_THAT(execute_binary_operation(
287283
Instr::i32_div_s, uint32_t(std::numeric_limits<int32_t>::min()), uint32_t(-1)),
288284
Traps());
@@ -379,7 +375,7 @@ TEST(execute_numeric, i32_shl)
379375

380376
TEST(execute_numeric, i32_shr_s)
381377
{
382-
// EXPECT_THAT(execute_binary_operation(Instr::i32_shr_s, uint64_t(-84), 1), Result(-42));
378+
EXPECT_THAT(execute_binary_operation(Instr::i32_shr_s, uint32_t(-84), 1), Result(-42));
383379
EXPECT_THAT(execute_binary_operation(Instr::i32_shr_s, 0xffffffff, 0), Result(0xffffffff));
384380
EXPECT_THAT(execute_binary_operation(Instr::i32_shr_s, 0xffffffff, 1), Result(0xffffffff));
385381
EXPECT_THAT(execute_binary_operation(Instr::i32_shr_s, 0xffffffff, 31), Result(0xffffffff));

0 commit comments

Comments
 (0)