fix: Rename misleading validate() function (#1075)

Bug: T422004

Author: dati18

app/Helper/DomainValidator.php

@@ -15,7 +15,7 @@ public function __construct(string $subDomainSuffix, array $subdomainRules) {
         $this->subdomainRules = $subdomainRules;
     }
 
-    public function validate($domain): \Illuminate\Validation\Validator {
+    public function getValidator($domain): \Illuminate\Validation\Validator {
 
         $isSubdomain = WikiController::isSubDomain($domain, $this->subDomainSuffix);
 

app/Helper/ProfileValidator.php

@@ -5,7 +5,7 @@
 use Illuminate\Support\Facades\Validator;
 
 class ProfileValidator {
-    public function validate($profile): \Illuminate\Validation\Validator {
+    public function getValidator($profile): \Illuminate\Validation\Validator {
 
         return Validator::make($profile, [
             'purpose' => 'in:data_hub,data_lab,tool_lab,test_drive,decide_later,other',

app/Http/Controllers/WikiController.php

@@ -47,7 +47,7 @@ public function create(Request $request): \Illuminate\Http\Response {
         $submittedDomain = strtolower($request->input('domain'));
         $submittedDomain = DomainHelper::encode($submittedDomain);
 
-        $domainValidator = $this->domainValidator->validate($submittedDomain);
+        $domainValidator = $this->domainValidator->getValidator($submittedDomain);
         $isSubdomain = $this->isSubDomain($submittedDomain);
 
         $domainValidator->validateWithBag('post');
@@ -70,7 +70,7 @@ public function create(Request $request): \Illuminate\Http\Response {
         $rawProfile = false;
         if ($request->filled('profile')) {
             $rawProfile = json_decode($request->input('profile'), true);
-            $profileValidator = $this->profileValidator->validate($rawProfile);
+            $profileValidator = $this->profileValidator->getValidator($rawProfile);
             $profileValidator->validateWithBag('post');
         }
 

app/Http/Controllers/WikiProfileController.php

@@ -21,7 +21,7 @@ public function create(Request $request): \Illuminate\Http\JsonResponse {
         ]);
 
         $rawProfile = json_decode($validatedInput['profile'], true);
-        $profileValidator = $this->profileValidator->validate($rawProfile);
+        $profileValidator = $this->profileValidator->getValidator($rawProfile);
         $profileValidator->validateWithBag('post');
 
         $profile = WikiProfile::create(['wiki_id' => $wiki->id, ...$rawProfile]);

tests/Helper/DomainValidatorTest.php

@@ -10,23 +10,23 @@
 class DomainValidatorTest extends TestCase {
     public function testValidatorUsesOldValidation() {
         $sut = new DomainValidator('.wbaas.localhost', []);
-        $validator = $sut->validate('derp');
+        $validator = $sut->getValidator('derp');
         $this->assertCount(1, $validator->errors());
     }
 
     public function testValidatorUsesList() {
         $sut = new DomainValidator('.wbaas.localhost', [
             new ForbiddenSubdomainRule(['long-terrible-word'], '.wbaas.localhost'),
         ]);
-        $validator = $sut->validate('long-terrible-word.wbaas.localhost');
+        $validator = $sut->getValidator('long-terrible-word.wbaas.localhost');
         $this->assertCount(1, $validator->errors());
         $this->assertEquals(ForbiddenSubdomainRule::ERROR_MESSAGE, $validator->errors()->get('domain')[0]);
     }
 
     public function testAppValidator() {
         Config::set('wbstack.subdomain_suffix', '.wbaas.localhost');
         $sut = $this->app->make(DomainValidator::class);
-        $validator = $sut->validate('statistics.wbaas.localhost');
+        $validator = $sut->getValidator('statistics.wbaas.localhost');
         $this->assertCount(1, $validator->errors());
         $this->assertEquals(ForbiddenSubdomainRule::ERROR_MESSAGE, $validator->errors()->get('domain')[0]);
     }

tests/Helper/ProfileValidatorTest.php

@@ -11,7 +11,7 @@ class ProfileValidatorTest extends TestCase {
      */
     public function testProfileValidatorWorksWithValidProfile($profile): void {
         $validatorFactory = new ProfileValidator;
-        $validator = $validatorFactory->validate($profile);
+        $validator = $validatorFactory->getValidator($profile);
         $this->assertTrue($validator->passes());
     }
 
@@ -20,7 +20,7 @@ public function testProfileValidatorWorksWithValidProfile($profile): void {
      */
     public function testProfileValidatorWorksWithInvalidProfile($profile): void {
         $validatorFactory = new ProfileValidator;
-        $validator = $validatorFactory->validate($profile);
+        $validator = $validatorFactory->getValidator($profile);
         $this->assertFalse($validator->passes());
     }