Fix: support FormData object on fetch body (#3417)

* refactor: make node-fetch external in rollup build

* deps: make node-fetch standard dep

* refactor: switch to node-fetch pkg ref in fetch.ts

* chore: changeset

* chore: bump webapi to minor change

Author: bholmesdev

.changeset/serious-vans-smell.md

@@ -0,0 +1,6 @@
+---
+'@astrojs/webapi': minor
+'astro': patch
+---
+
+Fix: support FormData object on fetch body

packages/webapi/package.json

@@ -49,6 +49,9 @@
   ],
   "bugs": "https://github.com/withastro/astro/issues",
   "homepage": "https://github.com/withastro/astro/tree/main/packages/webapi#readme",
+  "dependencies": {
+    "node-fetch": "^3.2.4"
+  },
   "devDependencies": {
     "@rollup/plugin-alias": "^3.1.9",
     "@rollup/plugin-inject": "^4.0.4",
@@ -65,7 +68,6 @@
     "formdata-polyfill": "^4.0.10",
     "magic-string": "^0.25.9",
     "mocha": "^9.2.2",
-    "node-fetch": "^3.2.4",
     "rollup": "^2.74.1",
     "rollup-plugin-terser": "^7.0.2",
     "tslib": "^2.4.0",

packages/webapi/run/build.js

@@ -178,6 +178,7 @@ async function build() {
 			inputOptions: {
 				input: 'src/polyfill.ts',
 				plugins: plugins,
+				external: ['node-fetch'],
 				onwarn(warning, warn) {
 					if (warning.code !== 'UNRESOLVED_IMPORT') warn(warning)
 				},

packages/webapi/src/lib/fetch.ts

@@ -3,15 +3,16 @@ import {
 	Headers,
 	Request,
 	Response,
-} from 'node-fetch/src/index.js'
+} from 'node-fetch'
+import type { RequestInit } from 'node-fetch'
 import Stream from 'node:stream'
 import * as _ from './utils'
 
 export { Headers, Request, Response }
 
 export const fetch = {
 	fetch(
-		resource: string | URL | Request,
+		resource: string | Request,
 		init?: Partial<FetchInit>
 	): Promise<Response> {
 		const resourceURL = new URL(
@@ -62,13 +63,7 @@ export const fetch = {
 type USVString = {} & string
 
 interface FetchInit {
-	body:
-		| Blob
-		| BufferSource
-		| FormData
-		| URLSearchParams
-		| ReadableStream
-		| USVString
+	body: RequestInit['body']
 	cache:
 		| 'default'
 		| 'no-store'