feat(app): app.render optional object

Author: lilnasy

.changeset/sharp-starfishes-compete.md

@@ -0,0 +1,11 @@
+---
+'astro': major
+---
+
+The adapter API now offers a simpler signature for rendering. The `render()` method on App now accepts an `options` object.
+
+```diff
+- app.render(request, undefined, locals)
++ app.render(request, { locals })
+```
+The current signature is deprecated but will continue to function until next major version.

packages/astro/src/core/app/index.ts

@@ -145,7 +145,26 @@ export class App {
 		return routeData;
 	}
 
-	async render(request: Request, routeData?: RouteData, locals?: object): Promise<Response> {
+	async render(request: Request, options?: { routeData?: RouteData, locals?: object }): Promise<Response>
+	async render(request: Request, routeData?: RouteData, locals?: object): Promise<Response>
+	async render(request: Request): Promise<Response> {
+		let routeData: RouteData | undefined;
+		let locals: object | undefined;
+
+		if (arguments.length === 3) {
+			routeData = arguments[1];
+			locals = arguments[2];
+		}
+		else if (arguments.length === 2) {
+			const options = arguments[1];
+			if (options && 'routeData' in options) {
+				routeData = options.routeData;
+			}
+			if (options && 'locals' in options) {
+				locals = options.locals;
+			}
+		}
+
 		// Handle requests with duplicate slashes gracefully by cloning with a cleaned-up request URL
 		if (request.url !== collapseDuplicateSlashes(request.url)) {
 			request = new Request(collapseDuplicateSlashes(request.url), request);

packages/astro/src/core/app/node.ts

@@ -116,11 +116,29 @@ export class NodeApp extends App {
 		}
 		return super.match(req, opts);
 	}
-	render(req: NodeIncomingMessage | Request, routeData?: RouteData, locals?: object) {
+	render(request: NodeIncomingMessage | Request, options?: { routeData?: RouteData, locals?: object }): Promise<Response>
+	render(request: NodeIncomingMessage | Request, routeData?: RouteData, locals?: object): Promise<Response>
+	render(req: NodeIncomingMessage | Request) {
+		let routeData: RouteData | undefined;
+		let locals: object | undefined;
+
+		if (arguments.length === 3) {
+			routeData = arguments[1];
+			locals = arguments[2];
+		}
+		else if (arguments.length === 2) {
+			const options = arguments[1];
+			if (options && 'routeData' in options) {
+				routeData = options.routeData;
+			}
+			if (options && 'locals' in options) {
+				locals = options.locals;
+			}
+		}
 		if (!(req instanceof Request)) {
 			req = createRequestFromNodeRequest(req);
 		}
-		return super.render(req, routeData, locals);
+		return super.render(req, { routeData, locals });
 	}
 }