feat!: remove Astro.glob (#14421)

Co-authored-by: Sarah Rainsberger <5098874+sarah11918@users.noreply.github.com>

Author: florian-lefebvre

.changeset/kind-pears-behave.md

@@ -0,0 +1,24 @@
+---
+'astro': major
+---
+
+Removes `Astro.glob()`
+
+In Astro 5.0, `Astro.glob()` was deprecated in favor of using `getCollection()` to query your collections, and `import.meta.glob()` to query other source files in your project.
+
+Astro 6.0 removes `Astro.glob()` entirely. Update to `import.meta.glob()` to keep your current behavior.
+
+#### What should I do?
+
+Replace all use of `Astro.glob()` with `import.meta.glob()`. Note that `import.meta.glob()` no longer returns a `Promise`, so you may have to update your code accordingly. You should not require any updates to your glob patterns.
+
+```astro
+---
+// src/pages/blog.astro
+-const posts = await Astro.glob('./posts/*.md');
++const posts = Object.values(import.meta.glob('./posts/*.md', { eager: true }));
+---
+{posts.map((post) => <li><a href={post.url}>{post.frontmatter.title}</a></li>)}
+```
+
+Where appropriate, consider using content collections to organize your content, which has its own newer, more performant querying functions.

packages/astro/e2e/errors.test.js

@@ -117,18 +117,6 @@ test.describe('Error display', () => {
 		expect(await page.locator('vite-error-overlay').count()).toEqual(0);
 	});
 
-	test('astro glob no match error', async ({ page, astro }) => {
-		await page.goto(astro.resolveUrl('/astro-glob-no-match'), { waitUntil: 'networkidle' });
-		const message = (await getErrorOverlayContent(page)).message;
-		expect(message).toMatch('did not return any matching files');
-	});
-
-	test('astro glob used outside of an astro file', async ({ page, astro }) => {
-		await page.goto(astro.resolveUrl('/astro-glob-outside-astro'), { waitUntil: 'networkidle' });
-		const message = (await getErrorOverlayContent(page)).message;
-		expect(message).toMatch('can only be used in');
-	});
-
 	test('can handle DomException errors', async ({ page, astro }) => {
 		await page.goto(astro.resolveUrl('/dom-exception'), { waitUntil: 'networkidle' });
 		const message = (await getErrorOverlayContent(page)).message;

packages/astro/e2e/fixtures/errors/src/components/AstroGlobOutsideAstro.js

@@ -113,7 +113,6 @@
     "@capsizecss/unpack": "^2.4.0",
     "@oslojs/encoding": "^1.1.0",
     "@rollup/pluginutils": "^5.2.0",
-    "acorn": "^8.15.0",
     "aria-query": "^5.3.2",
     "axobject-query": "^4.1.0",
     "boxen": "8.0.1",
@@ -130,7 +129,6 @@
     "dset": "^3.1.4",
     "es-module-lexer": "^1.7.0",
     "esbuild": "^0.25.0",
-    "estree-walker": "^3.0.3",
     "flattie": "^1.1.1",
     "fontace": "~0.3.0",
     "github-slugger": "^2.0.0",

packages/astro/e2e/fixtures/errors/src/pages/astro-glob-no-match.astro

@@ -22,7 +22,6 @@ import astroDevToolbar from '../toolbar/vite-plugin-dev-toolbar.js';
 import astroTransitions from '../transitions/vite-plugin-transitions.js';
 import type { AstroSettings, RoutesList } from '../types/astro.js';
 import astroVitePlugin from '../vite-plugin-astro/index.js';
-import astroPostprocessVitePlugin from '../vite-plugin-astro-postprocess/index.js';
 import { vitePluginAstroServer } from '../vite-plugin-astro-server/index.js';
 import configAliasVitePlugin from '../vite-plugin-config-alias/index.js';
 import vitePluginFileURL from '../vite-plugin-fileurl/index.js';
@@ -158,7 +157,6 @@ export async function createVite(
 			astroEnv({ settings, sync, envLoader }),
 			markdownVitePlugin({ settings, logger }),
 			htmlVitePlugin(),
-			astroPostprocessVitePlugin(),
 			astroIntegrationsContainerPlugin({ settings, logger }),
 			astroScriptsPageSSRPlugin({ settings }),
 			astroHeadPlugin(),

packages/astro/e2e/fixtures/errors/src/pages/astro-glob-outside-astro.astro

@@ -97,7 +97,7 @@ If the error cannot be triggered at all anymore, it can deprecated by adding a `
 ```js
 /**
  * @docs
- * @deprecated Removed in Astro v9.8.6 as it is no longer relevant due to...
+ * @deprecated This error was removed in Astro v6.0.0 along with the removal of...
  */
 ```
 

packages/astro/package.json

@@ -6,7 +6,7 @@ import type { ErrorPayload } from 'vite';
 import type { SSRLoadedRenderer } from '../../../types/public/internal.js';
 import type { ModuleLoader } from '../../module-loader/index.js';
 import { AstroError, type ErrorWithMetadata } from '../errors.js';
-import { FailedToLoadModuleSSR, InvalidGlob, MdxIntegrationMissingError } from '../errors-data.js';
+import { FailedToLoadModuleSSR, MdxIntegrationMissingError } from '../errors-data.js';
 import { createSafeError } from '../utils.js';
 import { getDocsForError, renderErrorMarkdown } from './utils.js';
 
@@ -76,29 +76,6 @@ export function enhanceViteSSRError({
 				stack: safeError.stack,
 			}) as ErrorWithMetadata;
 		}
-
-		// Since Astro.glob is a wrapper around Vite's import.meta.glob, errors don't show accurate information, let's fix that
-		if (safeError.message.includes('Invalid glob')) {
-			const globPattern = /glob: "(.+)" \(/.exec(safeError.message)?.[1];
-
-			if (globPattern) {
-				safeError.message = InvalidGlob.message(globPattern);
-				safeError.name = 'InvalidGlob';
-				safeError.title = InvalidGlob.title;
-
-				const line = lns.findIndex((ln) => ln.includes(globPattern));
-
-				if (line !== -1) {
-					const column = lns[line]?.indexOf(globPattern);
-
-					safeError.loc = {
-						file: path,
-						line: line + 1,
-						column,
-					};
-				}
-			}
-		}
 	}
 
 	return safeError;

packages/astro/src/core/create-vite.ts

@@ -951,6 +951,7 @@ export const LocalImageUsedWrongly = {
  * - [Astro.glob](https://docs.astro.build/en/reference/api-reference/#astroglob)
  * @description
  * `Astro.glob()` can only be used in `.astro` files. You can use [`import.meta.glob()`](https://vite.dev/guide/features.html#glob-import) instead to achieve the same result.
+ * @deprecated This error was removed in Astro v6.0.0 along with the removal of `Astro.glob()`.
  */
 export const AstroGlobUsedOutside = {
 	name: 'AstroGlobUsedOutside',
@@ -966,6 +967,7 @@ export const AstroGlobUsedOutside = {
  * - [Astro.glob](https://docs.astro.build/en/reference/api-reference/#astroglob)
  * @description
  * `Astro.glob()` did not return any matching files. There might be a typo in the glob pattern.
+ * @deprecated This error was removed in Astro v6.0.0 along with the removal of `Astro.glob()`.
  */
 export const AstroGlobNoMatch = {
 	name: 'AstroGlobNoMatch',
@@ -1075,6 +1077,7 @@ export const FailedToLoadModuleSSR = {
  * - [Glob Patterns](https://docs.astro.build/en/guides/imports/#glob-patterns)
  * @description
  * Astro encountered an invalid glob pattern. This is often caused by the glob pattern not being a valid file path.
+ * @deprecated This error was removed in Astro v6.0.0 along with the removal of `Astro.glob()`.
  */
 export const InvalidGlob = {
 	name: 'InvalidGlob',