Page Link block: Cannot update text via link editing UI

[t-hamano]

Description

The link editing UI has both a text field and a link field. If the text field is changed, that change should be synchronized to the visual text as well.

This works correctly in the inline link format, but not in the Page Link block within a Navigation block. This issue seems to occur for the first time in WP 7.0.

Step-by-step reproduction instructions

1. Insert a Navigation block.
2. Click the inserter and insert "Sample Page".
3. Click the "Edit Link" button.
4. Update the text and click the Apply button.
5. The on-screen text does not change.

Screenshots, screen recording, code snippet

❌ WP 7.0 or Gutenberg trunk

1c5259800a6d8bba9bf309610e40e3f2.mp4

✅ WordPress 6.9

d07be152077085bc1029e8b508dd8598.mp4

Environment info

No response

Please confirm that you have searched existing issues in the repo.

• Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

• Yes

Please confirm which theme type you used for testing.

• Block
• Classic
• Hybrid (e.g. classic with theme.json)
• Not sure

[t-hamano]

I have identified that this issue was caused by #73825.

[t-hamano]

@jeryj @getdave, I think that the useHandleLinkChange hook is overly protecting custom labels. For example, what do you think about the following changes?

diff --git a/packages/block-library/src/navigation-link/shared/use-handle-link-change.js b/packages/block-library/src/navigation-link/shared/use-handle-link-change.js
index a785ba4ee3d..66b1fbcb0ca 100644
--- a/packages/block-library/src/navigation-link/shared/use-handle-link-change.js
+++ b/packages/block-library/src/navigation-link/shared/use-handle-link-change.js
@@ -44,7 +44,13 @@ export function useHandleLinkChange( { clientId, attributes, setAttributes } ) {
 
                        // Only include title when there's no existing label
                        // This preserves user-customized labels when updating links
-                       if ( ! attributes.label || attributes.label === '' ) {
+                       const isEntityChanged =
+                               updatedLink.id && updatedLink.id !== attributes.id;
+                       if (
+                               ! attributes.label ||
+                               attributes.label === '' ||
+                               ! isEntityChanged
+                       ) {
                                attrs.title = updatedLink.title;
                        }