pnpacpi: fix incorrect TEST_ALPHA() test

Alan-Cox · rafaeljw · commit cdc87c5a30f4 · 2012-12-07T23:11:14.000+01:00
TEST_ALPHA() is broken and always returns 0.

[akpm@linux-foundation.org: return false for '@' as well, per Bjorn]
Signed-off-by: Alan Cox &lt;alan@lxorguk.ukuu.org.uk&gt;
Signed-off-by: Andrew Morton &lt;akpm@linux-foundation.org&gt;
Cc: &lt;stable@vger.kernel.org&gt;
Signed-off-by: Rafael J. Wysocki &lt;rafael.j.wysocki@intel.com&gt;
diff --git a/drivers/pnp/pnpacpi/core.c b/drivers/pnp/pnpacpi/core.c
@@ -58,7 +58,7 @@ static inline int __init is_exclusive_device(struct acpi_device *dev)
 	if (!(('0' <= (c) && (c) <= '9') || ('A' <= (c) && (c) <= 'F'))) \
 		return 0
 #define TEST_ALPHA(c) \
-	if (!('@' <= (c) || (c) <= 'Z')) \
+	if (!('A' <= (c) && (c) <= 'Z')) \
 		return 0
 static int __init ispnpidacpi(const char *id)
 {

Original file line number	Diff line number	Diff line change
`@@ -58,7 +58,7 @@ static inline int __init is_exclusive_device(struct acpi_device *dev)`
`58`	`58`	`if (!(('0' <= (c) && (c) <= '9') \|\| ('A' <= (c) && (c) <= 'F'))) \`
`59`	`59`	`return 0`
`60`	`60`	`#define TEST_ALPHA(c) \`
`61`		`- if (!('@' <= (c) \|\| (c) <= 'Z')) \`
	`61`	`+ if (!('A' <= (c) && (c) <= 'Z')) \`
`62`	`62`	`return 0`
`63`	`63`	`static int __init ispnpidacpi(const char *id)`
`64`	`64`	`{`