Open
Conversation
The agent only enables capture rules from rulesets marked with AI mode. Add the missing Mode field to the OpenAI ruleset so dev builds can consume the published ruleset without local normalization. The runtime API-key injection tests also assert OpenAI semantic convention metadata. Add the default request model, operation, provider, and server address attributes directly to the OpenAI event capture so the generated dev ruleset carries the metadata expected by the agent.
Member
Author
|
Codex was creating integration tests and it needed a ruleset that exercised the full agent capabilities for openai. I had it make a PR of its changes for review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Mode: aiRationale
The agent only enables capture rules from rulesets marked with AI mode. The runtime API-key injection tests also expect OpenAI request model/provider/server metadata to come from the published dev ruleset rather than build-time normalization.
Validation
rules/openai@v1.yamlwith PyYAML and assertedMode: aiplus the expected OTEL attributes are present.