fix(designer-v2): change actiontype filter value from 'trigger' to 'triggers'#9130
fix(designer-v2): change actiontype filter value from 'trigger' to 'triggers'#9130lisajmeyer wants to merge 1 commit intoAzure:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Fixes the v2 trigger browse panel filter mismatch by aligning actionType filter values with what the connector browse logic expects.
Changes:
- Update
filters.actionTypevalues from singular to plural (trigger→triggers,action→actions) inBrowseView.
| categoryKey={selectedBrowseCategory.key} | ||
| connectorFilters={category.connectorFilters} | ||
| filters={{ actionType: isTrigger ? 'trigger' : 'action' }} | ||
| filters={{ actionType: isTrigger ? 'triggers' : 'actions' }} |
There was a problem hiding this comment.
These string literals are part of a shared contract between BrowseView and ConnectorBrowse filtering. To prevent future regressions (e.g., singular/plural mismatches), strongly consider replacing the inline strings with a shared enum/union type or exported constants (e.g., ActionTypeFilter.Triggers / Actions) used by both the code that sets the filter and the code that interprets it.
🔒 AI Validation PendingThis PR is from an external contributor. AI validation will be performed after manual review by a maintainer. Maintainers: Add the |
lisajmeyer
changed the title
Commit Type
Risk Level
What & Why
Fixes a bug in the v2 trigger browse panel where the actiontype filter is added as "trigger" singular, but in the connector browse the filter is checked against "triggers" plural, and so the filter always defaults to showing actions. This has two side effects:
This is only an issue when browsing via categories. Searching works as expected
Impact of Change
Test Plan
Contributors
Screenshots/Videos