Conversation
dfbf8ae to
1b8184d
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR migrates the package configuration from setup.py to pyproject.toml, streamlining build declarations and version management. Key changes include:
- Removal of legacy setup.py logic and introduction of pyproject.toml for modern build configuration and metadata.
- Extraction of the package’s version into mkl/_version.py and updating init.py accordingly.
- Updates in CI and conda recipe files to align with the new build process and dependency requirements.
Reviewed Changes
Copilot reviewed 9 out of 11 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| setup.py | Removed legacy build logic and updated extension definitions to work with pyproject.toml. |
| pyproject.toml | Introduced new build configuration and project metadata. |
| mkl/_version.py | Added version file to centrally manage the package version. |
| mkl/init.py | Updated version import to use the new mkl/_version module. |
| conda-recipe/meta.yaml | Adjusted dependency specifications and description to reference OneMKL. |
| CHANGELOG.md | Updated changelog to reflect new versioning and build process changes. |
| .github/workflows/conda-package.yml | Updated CI configuration for conda package building. |
| .github/workflows/build-with-clang.yml | Updated required setuptools version to be compatible with the new build process. |
| .github/dependabot.yml | Minor update to dependabot configuration. |
Files not reviewed (2)
- conda-recipe/bld.bat: Language not supported
- conda-recipe/build.sh: Language not supported
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
migrate from
setup.pytopyproject.toml