Conversation
vtavana
requested review from
antonwolfy,
ekomarova,
ndgrigorian and
xaleryb
as code owners
There was a problem hiding this comment.
Pull Request Overview
This PR adds pre-commit hooks and a corresponding GitHub Action workflow to improve code quality and enforce formatting rules across the repository. Other changes include minor formatting adjustments (such as standardizing string quotes) throughout the codebase.
- Updated setup.py and pyproject.toml for minor formatting consistency.
- Reformatted test and C extension files for clarity.
- Introduced .pre-commit-config.yaml and .github/workflows/pre-commit.yml for automated pre-commit checks.
Reviewed Changes
Copilot reviewed 12 out of 14 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| setup.py | Added missing comma in the libraries list and formatting cleanup |
| pyproject.toml | Removed superfluous blank line before the build-system section |
| mkl/tests/test_mkl_service.py | Standardized string literals and added a pylint disable comment |
| mkl/_mklinitmodule.c | Reformatted multi-line macro definitions for improved readability |
| mkl/init.py | Reformatting class comments and minor stylistic adjustments |
| examples/example.py | Changed single quotes to double quotes; note a typo in printed message |
| .pre-commit-config.yaml | New pre-commit configuration file with a variety of hooks |
| .github/workflows/pre-commit.yml | New GitHub Action to run the pre-commit hooks on push and pull requests |
Files not reviewed (2)
- .flake8: Language not supported
- .git-blame-ignore-revs: Language not supported
antonwolfy
reviewed
Apr 24, 2025
vtavana
force-pushed
the
precommit-hooks
branch
from
0a7b9f8 to
4085485
Compare
added 2 commits
April 24, 2025 11:27
antonwolfy
approved these changes
Apr 24, 2025
Collaborator
antonwolfy
left a comment
antonwolfy
left a comment
There was a problem hiding this comment.
LGTM! Thank you @vtavana
vtavana
force-pushed
the
precommit-hooks
branch
from
4085485 to
f07b915
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.