Support mkl-service in virtual environment out of the box#79
Merged
Support mkl-service in virtual environment out of the box#79
Conversation
|
Why not dynamically detect the location of the libraries using from importlib.metadata import files
dll = next(p for p in files("mkl") if p.match("*mkl_rt*.dll"))
dll_dir = dll.locate().resolve().parent
os.add_dll_directory(dll_dir)Here's a complete patch which handles errors and also works on Linux: If this looks good, I'd be happy to submit a PR along those lines. |
vtavana
reviewed
May 28, 2025
vtavana
approved these changes
May 28, 2025
Collaborator
Author
|
Can I merge it? Any objections? |
urob
added a commit
to urob/numpy-mkl
that referenced
this pull request
Jun 2, 2025
The fix in IntelPython/mkl-service#79 only works when all libraries are installed in default paths while our own patch dynamically detects the library path and hence works much more generally.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since location of "Library\bin" in the virtual environment is not on the default search path, importing of mkl_service fails.
This change introduces "_init_helper.py" file which implements the following logic using built-in os Python module: