clCopyImage: clean up image resources on failure#2667
Open
xinjin01 wants to merge 1 commit intoKhronosGroup:mainfrom
Open
clCopyImage: clean up image resources on failure#2667xinjin01 wants to merge 1 commit intoKhronosGroup:mainfrom
xinjin01 wants to merge 1 commit intoKhronosGroup:mainfrom
Conversation
The clCopyImage failure paths did not always release image resources promptly. If verification failed after mapping the destination image, the test returned before unmapping it. The image creation helpers also held raw cl_mem handles after clCreateImage(), so later setup failures could bypass cleanup. This could retain image-backed resources across repeated failing formats and drive the test into OOM. Fix this by unmapping the verification mapping before returning on ompare failure, and by taking ownership of created images with clMemWrapper immediately so later failures release them through RAII. Signed-off-by: Xin Jin <xin.jin@arm.com>
rjodinchr
approved these changes
Apr 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The clCopyImage failure paths did not always release image resources promptly. If verification failed after mapping the destination image, the test returned before unmapping it. The image creation helpers also held raw cl_mem handles after clCreateImage(), so later setup failures could bypass cleanup.
This could retain image-backed resources across repeated failing formats and drive the test into OOM.
Fix this by unmapping the verification mapping before returning on ompare failure, and by taking ownership of created images with clMemWrapper immediately so later failures release them through RAII.