USVM test for multithreaded alloc & free#2668
Open
EwanC wants to merge 2 commits intoKhronosGroup:cl_khr_unified_svmfrom
Open
USVM test for multithreaded alloc & free#2668EwanC wants to merge 2 commits intoKhronosGroup:cl_khr_unified_svmfrom
EwanC wants to merge 2 commits intoKhronosGroup:cl_khr_unified_svmfrom
Conversation
Allocation and free entry-points USVM entry-points should be threadsafe as they may be used in a threaded manner. Stresses the bug found in the USVM emulation layer bashbaug/SimpleOpenCLSamples#165
Without giving each thread it's own USVM wrapper we hit issues with double allocations, resulting in the wrapper doing an implicit free before the tests explicit free of the same ptr.
bashbaug
approved these changes
Apr 23, 2026
Contributor
bashbaug
left a comment
bashbaug
left a comment
There was a problem hiding this comment.
Thanks! Latest version LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allocation and free entry-points USVM entry-points should be threadsafe as they may be used in a threaded manner.
Stresses the bug found in the USVM emulation layer bashbaug/SimpleOpenCLSamples#165