Add pattern lifetime tests for clEnqueueFillBuffer and clEnqueueSVMMemFill#2677
Open
joselopeqti wants to merge 2 commits intoKhronosGroup:mainfrom
Open
Add pattern lifetime tests for clEnqueueFillBuffer and clEnqueueSVMMemFill#2677joselopeqti wants to merge 2 commits intoKhronosGroup:mainfrom
joselopeqti wants to merge 2 commits intoKhronosGroup:mainfrom
Conversation
bashbaug
reviewed
Apr 30, 2026
Comment on lines
+810
to
+814
| if (host_buffer) free(host_buffer); | ||
| if (pattern) free(pattern); | ||
| if (fill_event) clReleaseEvent(fill_event); | ||
| if (user_event) clReleaseEvent(user_event); | ||
| if (buffer) clReleaseMemObject(buffer); |
Contributor
There was a problem hiding this comment.
Can we use the RAII wrappers and either std::vectors or smart pointers in these tests so we don't need to clean this up manually?
Comment on lines
+464
to
+467
| if (fill_event) clReleaseEvent(fill_event); | ||
| if (user_event) clReleaseEvent(user_event); | ||
| if (pattern) free(pattern); | ||
| if (svm_ptr) clSVMFree(context, svm_ptr); |
Contributor
There was a problem hiding this comment.
Same comment here - can we use wrappers so we don't need to do this cleanup manually?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds tests that modify the pattern used before the fill command is executed.
Adds coverage for clEnqueueFillBuffer and clEnqueueSVMMemFill: