Add subject tagging activity feed#158
Draft
mhpob wants to merge 5 commits intoMapRVA:trunkfrom
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should add an initially-hidden section to the Activity feed that shows when an image has been tagged with a subject. I have not tried to add any logic necessary to collapse them, so I imagine it'll be one long stream.
On my test instance, it takes a refresh to get things to show up after the toggle has been activated. I'm not sure if I've introduced that somehow.
As usual, please be highly critical of any changes as I'm very much on the newly-learning side of the whole process.