feat(snap-account-service): track account management Snaps + add :getSnaps#8725
Open
feat(snap-account-service): track account management Snaps + add :getSnaps#8725
:getSnaps#8725Conversation
ccharly
changed the base branch from
main
to
cc/feat/snap-account-service-snap-platform
ccharly
force-pushed
the
cc/feat/snap-account-service-track-snaps
branch
from
239aa39 to
051934c
Compare
Base automatically changed from
cc/feat/snap-account-service-snap-platform
to
main
May 6, 2026 20:14
ccharly
force-pushed
the
cc/feat/snap-account-service-track-snaps
branch
from
051934c to
a6b5060
Compare
![cursor[bot]](https://avatars.gh.lumenfield.work/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 96d8578. Configure here.
ccharly
commented
May 7, 2026
Contributor
Author
There was a problem hiding this comment.
I thought on maybe naming it SnapAccountTracker? But that's not really "tracking accounts". We could go for AccountManagementSnapTracker though?
Contributor
Author
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. Learn how to use preview builds in other projects. Expand for full list of packages and versions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Tracking account management Snaps so we can "restrict" the use of this service only for those Snaps.
This will also be used later on to initialize their associated
SnapKeyringv2.References
N/A
Checklist
Note
Medium Risk
Medium risk because it changes
SnapAccountServicebehavior and messenger dependencies, andensureReadynow throws for untracked Snaps (potential consumer impact).Overview
Adds a new
SnapTrackerthat seeds fromSnapController:getRunnableSnapsoninit()and stays in sync via Snap lifecycle events, enablingSnapAccountService:getSnapsto return installed/enabled/non-blocked Snaps declaringendowment:keyring.Tightens
SnapAccountService.ensureReadyto fail fast withUnknown snap: "<id>"unless the Snap is currently tracked (and effectively requiresinit()to have run), and updates action types/exports, messenger requirements, tests, and changelog accordingly.Reviewed by Cursor Bugbot for commit fe37b4f. Bugbot is set up for automated code reviews on this repo. Configure here.