feat: add eip1193-compatilble as a supported session property#8731
Open
ffmcgee725 wants to merge 6 commits intomainfrom
Open
feat: add eip1193-compatilble as a supported session property#8731ffmcgee725 wants to merge 6 commits intomainfrom
ffmcgee725 wants to merge 6 commits intomainfrom
Conversation
5 tasks
Member
Author
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. Learn how to use preview builds in other projects. Expand for full list of packages and versions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
The
@metamask/connect-evmpackage is adding support for sendingsessionProperties: { 'eip1193-compatible': true }on everywallet_createSessionrequest (MetaMask/connect-monorepo#285). This lets the wallet distinguish EIP-1193-style connections established throughconnect-evmfrom pure Multichain API connections and other provider types like Solana Wallet Standard.However, the
chain-agnostic-permissionpackage validates session properties against a known set (KnownSessionPropertiesenum), and any unrecognized property causes the CAIP-25 caveat validator to throw. Without this change, the neweip1193-compatiblesession property would be rejected.This PR adds
Eip1193Compatible = 'eip1193-compatible'to theKnownSessionPropertiesenum so the wallet accepts it as a valid session property.References
connect-evmChecklist
Note
Low Risk
Low risk: adds a new allowed CAIP-25
sessionPropertieskey and tags legacy permission conversions with it, with no changes to scope/account validation logic beyond accepting this new flag.Overview
Adds support for the
eip1193-compatibleCAIP-25 session property by extendingKnownSessionPropertiesand related validation/tests sowallet_createSessionrequests carrying this flag are no longer rejected.Updates
getCaip25PermissionFromLegacyPermissionsto always setsessionProperties: { 'eip1193-compatible': true }, and adjusts unit tests plus the package changelog accordingly.Reviewed by Cursor Bugbot for commit fb7fa99. Bugbot is set up for automated code reviews on this repo. Configure here.