chore(ci): pin all GitHub Actions to SHA digests#1233
chore(ci): pin all GitHub Actions to SHA digests#1233fcanogab wants to merge 1 commit intoNVIDIA:mainfrom
Conversation
Replace all mutable version tag references across 23 workflow files with immutable SHA digests. Retains the version tag as an inline comment for human readability and because it's a Dependabot requirement. Pinning to immutable SHAs eliminates the risk of a compromised or reassigned upstream tag injecting malicious code into CI runs. Pinned actions: - actions/checkout@v6 => de0fac2e4500dabe0009e67214ff5f5447ce83dd - actions/checkout@v4 => 34e114876b0b11c390a56381ad16ebd13914f8d5 - actions/github-script@v9 => 373c709c69115d41ff229c7e5df9f8788daa9553 - actions/setup-node@v6 => 48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e - docker/login-action@v4 => 4907a6ddec9925e35a0a9e82d7399ccc52663121 - actions/upload-artifact@v7 => 043fb46d1a93c77aae656e7c1c64a875d1fc6a0a - actions/download-artifact@v4 => d3f86a106a0bac45b974a628896c90dbdf5c8093 - softprops/action-gh-release@v2 => 3bb12739c298aeb8a4eeaf626c5b8d85266b0e65 - actions/attest@v4 => 281a49d4cbb0a72c9575a50d18f6deb515a11deb Dependabot will keep these pins current via the github-actions ecosystem config added in NVIDIA#1188. Signed-off-by: Florencio Cano Gabarda <fcanogab@redhat.com> Co-authored-by: Cursor <cursoragent@cursor.com>
|
LGTM if you can fix the merge conflicts |
|
It would be nice to look at configuring Dependabot to propose bumps to these. Previously, using something like 100% supportive of this change as a best practice, by the way! I'm happy to propose the bot config after this lands unless there's an objection. (Obviously, those bot updates need to be checked and not blindly merged, or it defeats the purpose.) |
No concerns on my front, seems fine to me |
Summary
Replace all mutable version tag references across 23 workflow files with
immutable SHA digests. Pinning to immutable SHAs eliminates the risk of a
compromised or reassigned upstream tag injecting malicious code into CI runs.
Dependabot (configured in #1188) will keep these pins current automatically.
Related Issue
N/A
Changes
actions/checkout@v6→de0fac2e4500dabe0009e67214ff5f5447ce83ddactions/checkout@v4→34e114876b0b11c390a56381ad16ebd13914f8d5actions/github-script@v9→373c709c69115d41ff229c7e5df9f8788daa9553actions/setup-node@v6→48b55a011bda9f5d6aeb4c2d9c7362e8dae4041edocker/login-action@v4→4907a6ddec9925e35a0a9e82d7399ccc52663121actions/upload-artifact@v7→043fb46d1a93c77aae656e7c1c64a875d1fc6a0aactions/download-artifact@v4→d3f86a106a0bac45b974a628896c90dbdf5c8093softprops/action-gh-release@v2→3bb12739c298aeb8a4eeaf626c5b8d85266b0e65actions/attest@v4→281a49d4cbb0a72c9575a50d18f6deb515a11debTesting
mise run pre-commitpasses (lint, format, license headers, rust:check, rust:lint)Checklist
Made with Cursor