ci: forward CUOPT_SLACK_MENTION_ID secret to nightly-summary#1182
Merged
rgsl888prabhu merged 1 commit intoNVIDIA:mainfrom May 6, 2026
Merged
Conversation
The nightly_summary.sh script reads CUOPT_SLACK_MENTION_ID to mention a Slack user/group on new failures and new flaky tests, but the secret was never plumbed through the workflow. Declare it as an optional secret on the reusable nightly-summary workflow and forward it from the test workflow caller. Empty value preserves the no-mention default.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughTwo GitHub Actions workflow files are updated to introduce a new optional secret ChangesSlack Mention Secret Integration
Estimated code review effort🎯 2 (Simple) | ⏱️ ~5 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
jameslamb
approved these changes
May 6, 2026
3 tasks
rgsl888prabhu
added a commit
that referenced
this pull request
May 7, 2026
…1187) ## Summary - Detect user-group (subteam) IDs by their `S` prefix and emit `<!subteam^S...>` syntax. - User IDs (prefix `U`/`W`) continue to use `<@U...>`. - Update the contract comment to spell out both forms and warn that handle names alone will not ping. ## Why Today's nightly Slack post (2026-05-07) showed `@cuopt-ci-team` rendered as plain text — the message arrived but produced no notification. Root cause: `ci/utils/generate_slack_payloads.py` always wrapped `CUOPT_SLACK_MENTION_ID` as `<@id>`, which is **user-only** syntax. Slack requires `<!subteam^SXXXXXXXX>` to ping a user group. Passing the group's handle name (`cuopt-ci-team`) or its `S...` ID with the old formatter both fail silently. ## Test plan - [ ] `CUOPT_SLACK_MENTION_ID=SXXXXXXXX` → next nightly with new failures pings the `cuopt-ci-team` group. - [ ] Sanity-check that a user ID (`U...`) still renders as `<@U...>` (no behavior change for that path). - [ ] Empty/unset `CUOPT_SLACK_MENTION_ID` produces no mention (existing behavior preserved). ## Notes Builds on #1182, which plumbs the `CUOPT_SLACK_MENTION_ID` secret through the workflow. Either order of merge works; this PR only touches the formatter.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CUOPT_SLACK_MENTION_IDas an optionalworkflow_callsecret on the reusablenightly-summaryworkflow and forward it to the run-step env.test.yamlto thenightly-summaryjob alongside the other Slack secrets.Why
ci/nightly_summary.shalready forwardsCUOPT_SLACK_MENTION_IDtoci/utils/generate_slack_payloads.py, which uses it to prefix<@id>mentions on new failures and new flaky tests. Until now the env var was never populated in CI, so the mention was always empty. With this change, setting theCUOPT_SLACK_MENTION_IDrepo secret (Slack user ID likeU01ABCDEFor group handle likeS01ABCDEF) will ping the configured handle. Leaving it unset preserves the no-mention default.Test plan
CUOPT_SLACK_MENTION_IDrepo secret.workflow_dispatchonnightly-summary) and confirm the Slack message includes the<@id>mention on new failures.