Address HMR parsing review feedback

Agent-Logs-Url: https://github.com/NativeScript/nativescript-cli/sessions/58c98aaf-7d9e-410b-b92b-0708f4ff4655

Co-authored-by: NathanWalker <457187+NathanWalker@users.noreply.github.com>

Author: Copilot

lib/data/prepare-data.ts

@@ -2,6 +2,10 @@ import { IOptions } from "../declarations";
 import { ControllerDataBase } from "./controller-data-base";
 import * as _ from "lodash";
 
+function isTruthyBooleanValue(value: unknown): boolean {
+	return value === true || value === "true";
+}
+
 export class PrepareData extends ControllerDataBase {
 	public release: boolean;
 	public hmr: boolean;
@@ -34,10 +38,9 @@ export class PrepareData extends ControllerDataBase {
 		}
 
 		const hmr =
-			data.hmr ||
-			data.useHotModuleReload ||
-			env.hmr === true ||
-			env.hmr === "true";
+			isTruthyBooleanValue(data.hmr) ||
+			isTruthyBooleanValue(data.useHotModuleReload) ||
+			isTruthyBooleanValue(env.hmr);
 
 		this.release = data.release;
 		this.hmr = hmr;

lib/options.ts

@@ -378,7 +378,7 @@ export class Options {
 	}
 
 	private isHmrEnabled(): boolean {
-		if (process.argv.includes("--no-hmr")) {
+		if (this.isHmrExplicitlyDisabled()) {
 			return false;
 		}
 
@@ -388,6 +388,19 @@ export class Options {
 		);
 	}
 
+	private isHmrExplicitlyDisabled(): boolean {
+		return hideBin(process.argv).some((arg) => {
+			if (arg !== "--no-hmr" && arg !== "--noHmr") {
+				return (
+					arg === "--no-hmr=true" ||
+					arg === "--noHmr=true"
+				);
+			}
+
+			return true;
+		});
+	}
+
 	private isTruthyBooleanValue(value: unknown): boolean {
 		return value === true || value === "true";
 	}