Skip to content

Commit 5b40da7

Browse files
Clean up HMR option parsing changes
Agent-Logs-Url: https://github.com/NativeScript/nativescript-cli/sessions/58c98aaf-7d9e-410b-b92b-0708f4ff4655 Co-authored-by: NathanWalker <457187+NathanWalker@users.noreply.github.com>
1 parent e5ce2f8 commit 5b40da7

2 files changed

Lines changed: 12 additions & 16 deletions

File tree

lib/options.ts

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,6 @@ export class Options {
3737
_: { type: OptionType.String, hasSensitiveValue: false },
3838
};
3939

40-
private initialArgv: yargs.Arguments;
4140
public argv: yargs.Arguments;
4241
public options: IDictionary<IDashedOption>;
4342

@@ -52,7 +51,7 @@ export class Options {
5251
this.argv.bundle = "webpack";
5352
const isHmrEnabled = this.isHmrEnabled();
5453

55-
// Check if the user has explicitly provide --hmr and --release options from command line
54+
// Check if the user has explicitly enabled HMR together with --release.
5655
if (this.argv.release && isHmrEnabled) {
5756
this.$errors.fail(
5857
"The options --release and --hmr cannot be used simultaneously."
@@ -441,7 +440,6 @@ export class Options {
441440
// autocomplete matched completions
442441
return completions;
443442
});
444-
this.initialArgv = parsed.argv as any;
445443
this.argv = parsed.options(<any>opts).argv as any;
446444

447445
// For backwards compatibility

package-lock.json

Lines changed: 11 additions & 13 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)