This repository was archived by the owner on Dec 19, 2025. It is now read-only.
ASGARD-4 : Allow creation of multi-AZ RDS DB instances#316
Open
acasas wants to merge 4 commits intoNetflix:masterfrom
Open
ASGARD-4 : Allow creation of multi-AZ RDS DB instances#316acasas wants to merge 4 commits intoNetflix:masterfrom
acasas wants to merge 4 commits intoNetflix:masterfrom
Conversation
Contributor
|
I noticed that this pull request contains the two commits from your last pull request. That is a bit misleading, and will probably result in an unmergeable pull request (one the #315 is merged). But it seems to have exposed a Github bug where my comment was pulled in again. I also notice that #315 was done on master. |
|
asgard-pull-requests #74 SUCCESS |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should contain the custom validator for the availabilityZone constraint based on the value of multiAZ, an appropriate display of zones in the list of RDS instances, and some JS logic to disable availibilty zones selection if the multipleAZ is checked.