Skip to content

[19.0][MIG] project_timeline_hr_timesheet: Migration to 19.0#1711

Open
stferraro wants to merge 22 commits intoOCA:19.0from
Jenrax-git:19.0-mig-project_timeline_hr_timesheet
Open

[19.0][MIG] project_timeline_hr_timesheet: Migration to 19.0#1711
stferraro wants to merge 22 commits intoOCA:19.0from
Jenrax-git:19.0-mig-project_timeline_hr_timesheet

Conversation

@stferraro
Copy link
Copy Markdown

No description provided.

tarteo and others added 20 commits April 23, 2026 14:51
[IMP] Enable auto install
[UPD] Update project_timeline_hr_timesheet.pot
[UPD] Update project_timeline_hr_timesheet.pot

[UPD] README.rst

Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: project-14.0/project-14.0-project_timeline_hr_timesheet
Translate-URL: https://translation.odoo-community.org/projects/project-14-0/project-14-0-project_timeline_hr_timesheet/
TT40299

project_timeline_hr_timesheet 14.0.1.0.1
@OCA-git-bot OCA-git-bot added series:19.0 mod:project_timeline_hr_timesheet Module project_timeline_hr_timesheet labels Apr 23, 2026
@stferraro
Copy link
Copy Markdown
Author

@pedrobaeza Hi please approved this pr #1710

@stferraro stferraro mentioned this pull request Apr 23, 2026
41 tasks
Copy link
Copy Markdown

@WesleyOliveira98 WesleyOliveira98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Missing pre-commit auto-fixes commit
  • It's necessary to squash your last 2 commits into one
  • The PR title is not following the OCA patterns
  • Missing test-requirements.txt for the unrealesed dependencie, see this example: OCA/sale-workflow@cc16164

Check: https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-19.0

@stferraro stferraro force-pushed the 19.0-mig-project_timeline_hr_timesheet branch from 6e2418b to a0159f0 Compare April 26, 2026 02:33
@stferraro
Copy link
Copy Markdown
Author

Hi @WesleyOliveira98,

I have fixed the pre-commit issues and updated the migration PR.

The dependency web_timeline is currently under migration in:
OCA/web#3521

Since OCA CI does not allow git-based dependencies in test-requirements.txt in #1710 , the build is failing until that PR is merged.

Could you please review/merge that PR so this migration can proceed?

Thanks!

Copy link
Copy Markdown

@WesleyOliveira98 WesleyOliveira98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • You can add a test-requirements.txt for the OCA/web#3521 and the #1710 in a separate commit named [DON'T MERGE] test-requirements.txt so the runboat and the tests CI will work
  • The PR title stll not following the OCA patterns, should be:
    [19.0][MIG] <module>: Migration to 19.0

https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-19.0#how-to
Image

@stferraro stferraro force-pushed the 19.0-mig-project_timeline_hr_timesheet branch from a0159f0 to 8dd0f04 Compare April 28, 2026 01:33
@stferraro stferraro force-pushed the 19.0-mig-project_timeline_hr_timesheet branch 2 times, most recently from ce6e9ce to c77ab8f Compare April 28, 2026 01:42
Copy link
Copy Markdown

@WesleyOliveira98 WesleyOliveira98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stferraro you need to change the PR title to [19.0][MIG] <module>: Migration to 19.0, the commit title was correct, should be [MIG] <module>: Migration to 19.0

Image

Everything else is ok, just change this

Ps: This PR will still open until the dependencies is not merged, but the community will be able to test it in runboat, after the merge of the dependency, remove the "DON'T MERGE" commit and test-dependencies.txt

Comment thread test-requirements.txt
@@ -0,0 +1 @@
odoo-addon-project_timeline @ git+https://github.com/OCA/project.git@refs/pull/1710/head#subdirectory=project_timeline
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add your PR #1710 in the test-requirements.txt for the runboat be able for testing

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to be both OCA/web#3521 and #1710

@stferraro stferraro force-pushed the 19.0-mig-project_timeline_hr_timesheet branch 2 times, most recently from 97bf4c9 to 5515de2 Compare April 28, 2026 15:49
Copy link
Copy Markdown

@WesleyOliveira98 WesleyOliveira98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • In your PR, click on this button:
Image
  • Insert the title: [19.0][MIG] project_timeline_hr_timesheet: Migration to 19.0

  • Click on save

Image
  • Then, change the commit message: [MIG] project_timeline_hr_timesheet: Migration to 19.0
  • Separate the test-requirements.txt file to one commit with message: [DON'T MERGE] test-requirements.txt

Comment thread test-requirements.txt
@@ -0,0 +1 @@
odoo-addon-project_timeline @ git+https://github.com/OCA/project.git@refs/pull/1710/head#subdirectory=project_timeline
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to be both OCA/web#3521 and #1710

@stferraro stferraro changed the title 19.0 mig project timeline hr timesheet [19.0][MIG] project_timeline_hr_timesheet: Migration to 19.0 Apr 28, 2026
@stferraro stferraro force-pushed the 19.0-mig-project_timeline_hr_timesheet branch 2 times, most recently from 3957e29 to afce3c8 Compare April 28, 2026 20:05
Copy link
Copy Markdown

@WesleyOliveira98 WesleyOliveira98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also need to change the first commit message for "[MIG] project_timeline_hr_timesheet: Migration to 19.0" and the second one with message "[DON'T MERGE] test-requirements.txt"

Comment thread test-requirements.txt Outdated
@@ -0,0 +1,2 @@
odoo-addon-project_timeline @ git+https://github.com/OCA/project.git@refs/pull/1710/head#subdirectory=project_timeline
odoo-addon-web_timeline @ git+https://github.com/OCA/web_timeline.git@refs/pull/3521/head#subdirectory=web_timeline
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the runboat still with error, need to be https://github.com/OCA/web.git instead of https://github.com/OCA/web_timeline.git

@stferraro stferraro force-pushed the 19.0-mig-project_timeline_hr_timesheet branch from 9f26cbf to de827cb Compare April 28, 2026 23:52
Copy link
Copy Markdown

@WesleyOliveira98 WesleyOliveira98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename this commit c77ab8f to: "[MIG] project_timeline_hr_timesheet: Migration to 19.0"
Squash this two commits a8e8ab0 de827cb with message: "[DON'T MERGE] test-requirements.txt"

Comment thread test-requirements.txt Outdated
@@ -0,0 +1,2 @@
odoo-addon-project_timeline @ git+https://github.com/Jenrax-git/project.git@19.0-mig-project_timeline#subdirectory=project_timeline
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reference the OCA PRs, not your forks...

@stferraro stferraro force-pushed the 19.0-mig-project_timeline_hr_timesheet branch from de827cb to 39ab499 Compare April 29, 2026 14:01
@stferraro
Copy link
Copy Markdown
Author

hi, @CristianoMafraJunior check this pr please !

Copy link
Copy Markdown

@WesleyOliveira98 WesleyOliveira98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown

@WesleyOliveira98 WesleyOliveira98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @stferraro, since OCA/web#3521 is merged, remove it from the test-requiments.txt but maintain #1710 until merge

@stferraro stferraro force-pushed the 19.0-mig-project_timeline_hr_timesheet branch from 39ab499 to 6a602e9 Compare April 30, 2026 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

mod:project_timeline_hr_timesheet Module project_timeline_hr_timesheet series:19.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.