[19.0][MIG] project_timeline_hr_timesheet: Migration to 19.0#1711
[19.0][MIG] project_timeline_hr_timesheet: Migration to 19.0#1711
Conversation
[IMP] Enable auto install
[UPD] Update project_timeline_hr_timesheet.pot
[UPD] Update project_timeline_hr_timesheet.pot [UPD] README.rst Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: project-14.0/project-14.0-project_timeline_hr_timesheet Translate-URL: https://translation.odoo-community.org/projects/project-14-0/project-14-0-project_timeline_hr_timesheet/
TT40299 project_timeline_hr_timesheet 14.0.1.0.1
|
@pedrobaeza Hi please approved this pr #1710 |
WesleyOliveira98
left a comment
There was a problem hiding this comment.
- Missing pre-commit auto-fixes commit
- It's necessary to squash your last 2 commits into one
- The PR title is not following the OCA patterns
- Missing test-requirements.txt for the unrealesed dependencie, see this example: OCA/sale-workflow@cc16164
Check: https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-19.0
6e2418b to
a0159f0
Compare
|
I have fixed the pre-commit issues and updated the migration PR. The dependency Since OCA CI does not allow git-based dependencies in test-requirements.txt in #1710 , the build is failing until that PR is merged. Could you please review/merge that PR so this migration can proceed? Thanks! |
WesleyOliveira98
left a comment
There was a problem hiding this comment.
- You can add a test-requirements.txt for the OCA/web#3521 and the #1710 in a separate commit named
[DON'T MERGE] test-requirements.txtso the runboat and the tests CI will work - The PR title stll not following the OCA patterns, should be:
[19.0][MIG] <module>: Migration to 19.0
https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-19.0#how-to

a0159f0 to
8dd0f04
Compare
ce6e9ce to
c77ab8f
Compare
WesleyOliveira98
left a comment
There was a problem hiding this comment.
@stferraro you need to change the PR title to [19.0][MIG] <module>: Migration to 19.0, the commit title was correct, should be [MIG] <module>: Migration to 19.0
Everything else is ok, just change this
Ps: This PR will still open until the dependencies is not merged, but the community will be able to test it in runboat, after the merge of the dependency, remove the "DON'T MERGE" commit and test-dependencies.txt
| @@ -0,0 +1 @@ | |||
| odoo-addon-project_timeline @ git+https://github.com/OCA/project.git@refs/pull/1710/head#subdirectory=project_timeline | |||
There was a problem hiding this comment.
Add your PR #1710 in the test-requirements.txt for the runboat be able for testing
There was a problem hiding this comment.
Need to be both OCA/web#3521 and #1710
97bf4c9 to
5515de2
Compare
WesleyOliveira98
left a comment
There was a problem hiding this comment.
- In your PR, click on this button:
-
Insert the title: [19.0][MIG] project_timeline_hr_timesheet: Migration to 19.0
-
Click on save
- Then, change the commit message: [MIG] project_timeline_hr_timesheet: Migration to 19.0
- Separate the test-requirements.txt file to one commit with message: [DON'T MERGE] test-requirements.txt
| @@ -0,0 +1 @@ | |||
| odoo-addon-project_timeline @ git+https://github.com/OCA/project.git@refs/pull/1710/head#subdirectory=project_timeline | |||
There was a problem hiding this comment.
Need to be both OCA/web#3521 and #1710
3957e29 to
afce3c8
Compare
WesleyOliveira98
left a comment
There was a problem hiding this comment.
Also need to change the first commit message for "[MIG] project_timeline_hr_timesheet: Migration to 19.0" and the second one with message "[DON'T MERGE] test-requirements.txt"
| @@ -0,0 +1,2 @@ | |||
| odoo-addon-project_timeline @ git+https://github.com/OCA/project.git@refs/pull/1710/head#subdirectory=project_timeline | |||
| odoo-addon-web_timeline @ git+https://github.com/OCA/web_timeline.git@refs/pull/3521/head#subdirectory=web_timeline | |||
There was a problem hiding this comment.
the runboat still with error, need to be https://github.com/OCA/web.git instead of https://github.com/OCA/web_timeline.git
9f26cbf to
de827cb
Compare
| @@ -0,0 +1,2 @@ | |||
| odoo-addon-project_timeline @ git+https://github.com/Jenrax-git/project.git@19.0-mig-project_timeline#subdirectory=project_timeline | |||
There was a problem hiding this comment.
Reference the OCA PRs, not your forks...
de827cb to
39ab499
Compare
|
hi, @CristianoMafraJunior check this pr please ! |
WesleyOliveira98
left a comment
There was a problem hiding this comment.
Hi @stferraro, since OCA/web#3521 is merged, remove it from the test-requiments.txt but maintain #1710 until merge
39ab499 to
6a602e9
Compare
No description provided.