Add hadolint check in CI

.github/workflows/linting.yml

@@ -25,3 +25,12 @@ jobs:
         run: |
           npm install -g markdownlint-cli
           markdownlint *.md
+  hadolint:
+    name: hadolint
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+      - name: Run Hadolint
+        uses: hadolint/hadolint-action@v3.1.0
+        with:
+          recursive: true

.hadolint.yml

@@ -0,0 +1,3 @@
+ignored:
+  - DL3008
+  - DL3028

CHANGELOG.md

@@ -12,6 +12,7 @@
 * Ability to set Web Builder url via `WEB_BUILDER_URL`
 * Add `yamllint` check in CI
 * Add `dependabot` check for `GitHub Actions`
+* Add `hadolint` check in CI.
 
 ### Changes
 

Dockerfile

@@ -1,25 +1,28 @@
 FROM ruby:3.3
 
-MAINTAINER Pavel.Lobashov "shockwavenn@gmail.com"
-
-RUN apt-get update && apt-get -y -q install git curl
-RUN apt-get update && apt-get -y -q install libmagic-dev \
-                                            poppler-utils \
-                                            time
-
+RUN apt-get update && \
+    apt-get --no-install-recommends -y -q install \
+        curl \
+        git \
+        libmagic-dev \
+        poppler-utils \
+        time && \
+    rm -rf /var/lib/apt/lists/*
 RUN gem install bundler
 COPY . /doc-builder-testing
 WORKDIR /doc-builder-testing
 RUN bundle config set without 'development' && \
     bundle install
 # Install gpg key
-RUN mkdir -p -m 700 ~/.gnupg
-RUN curl -fsSL https://download.onlyoffice.com/GPG-KEY-ONLYOFFICE | gpg --no-default-keyring --keyring gnupg-ring:/tmp/onlyoffice.gpg --import
-RUN chmod 644 /tmp/onlyoffice.gpg
-RUN chown root:root /tmp/onlyoffice.gpg
-RUN mv /tmp/onlyoffice.gpg /usr/share/keyrings/onlyoffice.gpg
+SHELL ["/bin/bash", "-o", "pipefail", "-c"]
+RUN mkdir -m 700 ~/.gnupg && \
+    curl -fsSL https://download.onlyoffice.com/GPG-KEY-ONLYOFFICE | gpg --no-default-keyring --keyring gnupg-ring:/tmp/onlyoffice.gpg --import && \
+    chmod 644 /tmp/onlyoffice.gpg && \
+    chown root:root /tmp/onlyoffice.gpg && \
+    mv /tmp/onlyoffice.gpg /usr/share/keyrings/onlyoffice.gpg
 # Write repository & install docbuilder
 RUN echo "deb [signed-by=/usr/share/keyrings/onlyoffice.gpg] http://download.onlyoffice.com/repo/debian squeeze main" >> /etc/apt/sources.list.d/onlyoffice.list && \
     apt-get -y update && \
-    apt-get -y install onlyoffice-documentbuilder
-ENTRYPOINT ["rake"]
+    apt-get --no-install-recommends -y install onlyoffice-documentbuilder && \
+    rm -rf /var/lib/apt/lists/*
+CMD ["bash", "entrypoint.sh"]

dockerfiles/debian-develop/Dockerfile

@@ -1,25 +1,27 @@
 FROM ruby:3.3
 
-MAINTAINER Pavel.Lobashov "shockwavenn@gmail.com"
 ENV VERSION="99.99.99"
 ENV DIST="stable"
 
-RUN apt-get update && apt-get -y -q install git \
-                                            curl \
-                                            libmagic-dev \
-                                            poppler-utils
+RUN apt-get update && \
+    apt-get --no-install-recommends -y -q install \
+                          git \
+                          curl \
+                          libmagic-dev \
+                          poppler-utils && \
+    rm -rf /var/lib/apt/lists/*
 
 RUN gem install bundler
 COPY . /doc-builder-testing
 WORKDIR /doc-builder-testing
 RUN bundle config set without 'development' && \
     bundle install
+SHELL ["/bin/bash", "-o", "pipefail", "-c"]
 RUN echo "deb [trusted=yes] https://s3.eu-west-1.amazonaws.com/repo-doc-onlyoffice-com/repo/debian $DIST $VERSION" | \
     tee /etc/apt/sources.list.d/onlyoffice-dev.list && \
     apt-get -y update && \
-    apt-get -y install onlyoffice-documentbuilder
+    apt-get --no-install-recommends -y install onlyoffice-documentbuilder && \
+    rm -rf /var/lib/apt/lists/*
 RUN cat /etc/apt/sources.list.d/onlyoffice-dev.list
 
-CMD /bin/bash -c "onlyoffice-documentbuilder -v; \
-                  cd /doc-builder-testing; \
-                  rake rspec_critical"
+CMD ["sh", "dockerfiles/entrypoint.sh"]

dockerfiles/debian-next-release/Dockerfile

@@ -4,22 +4,25 @@ MAINTAINER Pavel.Lobashov "shockwavenn@gmail.com"
 ENV VERSION="8.2.1"
 ENV DIST="stable"
 
-RUN apt-get update && apt-get -y -q install git \
-                                            curl \
-                                            libmagic-dev \
-                                            poppler-utils
+RUN apt-get update && \
+    apt-get --no-install-recommends -y -q install \
+                          git \
+                          curl \
+                          libmagic-dev \
+                          poppler-utils && \
+    rm -rf /var/lib/apt/lists/*
 
 RUN gem install bundler
 COPY . /doc-builder-testing
 WORKDIR /doc-builder-testing
 RUN bundle config set without 'development' && \
     bundle install
+SHELL ["/bin/bash", "-o", "pipefail", "-c"]
 RUN echo "deb [trusted=yes] https://s3.eu-west-1.amazonaws.com/repo-doc-onlyoffice-com/repo/debian $DIST $VERSION" | \
     tee /etc/apt/sources.list.d/onlyoffice-dev.list && \
     apt-get -y update && \
-    apt-get -y install onlyoffice-documentbuilder=$VERSION-*
+    apt-get --no-install-recommends -y install onlyoffice-documentbuilder=$VERSION-* && \
+    rm -rf /var/lib/apt/lists/*
 RUN cat /etc/apt/sources.list.d/onlyoffice-dev.list
 
-CMD /bin/bash -c "onlyoffice-documentbuilder -v; \
-                  cd /doc-builder-testing; \
-                  rake rspec_critical"
+CMD ["sh", "dockerfiles/entrypoint.sh"]

dockerfiles/entrypoint.sh

@@ -0,0 +1,5 @@
+#!/bin/bash
+
+onlyoffice-documentbuilder -v
+cd /doc-builder-testing
+rake rspec_critical

dockerfiles/rockylinux-latest/Dockerfile

@@ -6,6 +6,7 @@ RUN bundle config set without 'development' && \
     bundle install
 RUN bundle config set without 'development' && \
     bundle install
-RUN dnf -y install https://download.onlyoffice.com/repo/centos/main/noarch/onlyoffice-repo.noarch.rpm
-RUN dnf -y install onlyoffice-documentbuilder
-CMD rake rspec_critical
+RUN dnf -y install https://download.onlyoffice.com/repo/centos/main/noarch/onlyoffice-repo.noarch.rpm && \
+    dnf -y install onlyoffice-documentbuilder && \
+    dnf clean all
+CMD ["sh", "dockerfiles/entrypoint.sh"]

entrypoint.sh

@@ -0,0 +1,5 @@
+#!/bin/bash
+
+onlyoffice-documentbuilder -v
+cd /doc-builder-testing
+rake