feat: Add type+format mappings for go#21032
Open
cbascom wants to merge 1 commit intoOpenAPITools:masterfrom
Open
feat: Add type+format mappings for go#21032cbascom wants to merge 1 commit intoOpenAPITools:masterfrom
cbascom wants to merge 1 commit intoOpenAPITools:masterfrom
Conversation
We now register type+format mappings for the go generator so that types like integer with format uint64 get mapped correctly.
Member
|
thanks for the PR which go generator(s) do you use? we should add tests to cover this change. |
Contributor
Author
|
I use just the go generator for apis, clients, and models. I didn't see any existing tests for the type mappings, but I will look into getting some added. Seems like it should be easy to add in either AbstractGoCodgenTest.java or GoModelTest.java. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add type+format mappings for Go generator
Description
Adds support for explicit type+format mappings in the Go generator, allowing precise control over numeric types through both integer and number formats. This enhancement enables users to specify exact Go numeric types using OpenAPI's type and format fields.
New Type Mappings
Integer Format Mappings
Number Format Mappings
Default mappings remain unchanged:
integer→int32number→float32long→int64float→float32double→float64decimal→float64Usage Example
Closes: #21031
@antihax (2017/11) @grokify (2018/07) @kemokemo (2018/09) @jirikuncar (2021/01) @ph4r5h4d (2021/04) @lwj5 (2023/04)
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming7.x.0minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)