Skip to content

enable Reproducible Builds #21067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hboutemy wants to merge 1 commit into
base: master
Choose a base branch
from
Open

enable Reproducible Builds #21067

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion modules/openapi-generator-cli/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-shade-plugin</artifactId>
<version>3.2.0</version>
<version>3.6.0</version>
<executions>
<execution>
<id>process-resources</id>
Expand Down
2 changes: 1 addition & 1 deletion modules/openapi-generator-online/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
<packaging>jar</packaging>
<name>openapi-generator-online</name>
<properties>
<spring-boot.version>2.5.14</spring-boot.version>
<spring-boot.version>2.7.1</spring-boot.version>
<springfox-version>3.0.0</springfox-version>
<sonar.exclusions>**/org/openapitools/codegen/online/**/*</sonar.exclusions>
</properties>
Expand Down
3 changes: 2 additions & 1 deletion pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -283,7 +283,7 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-source-plugin</artifactId>
<version>3.0.1</version>
<version>3.3.1</version>
<executions>
<execution>
<id>attach-sources</id>
Expand Down Expand Up @@ -1212,6 +1212,7 @@
<properties>
<maven.compiler.source>11</maven.compiler.source>
<maven.compiler.target>11</maven.compiler.target>
<project.build.outputTimestamp>2025-04-09T17:14:21Z</project.build.outputTimestamp>
Copy link
Copy Markdown
Member

@wing328 wing328 Apr 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the PR. does it mean the build time stamp is hardcoded? do we need to update it regularly somehow?

Copy link
Copy Markdown
Author

@hboutemy hboutemy Apr 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is updated by versions:set when changing from SNAPSHOT to release and vice versa, or by maven-release-plugin
or you can also choose not to update but pick a purely conventional value

Copy link
Copy Markdown
Contributor

@reitzmichnicht reitzmichnicht Apr 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I recommend to set it instead to the timestamp of the latest git commit which can be done on every build
<project.build.outputTimestamp>${git.commit.timestamp.datetime}</project.build.outputTimestamp>

using https://github.com/qoomon/maven-git-versioning-extension

Copy link
Copy Markdown
Author

@hboutemy hboutemy Apr 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's a classical reaction from many people, as it seems a legitimate idea

just know that by doing so, you are killing any cache, as every commit will change the hash of every output archive, even if nothing changed

changing timestamp only on version updates limits the times when the cache will be de-facto flushed for any output of a multi-module Maven build

<archunit.version>1.3.0</archunit.version>
<checkstyle.plugin.version>3.1.0</checkstyle.plugin.version>
<commons-cli.version>1.5.0</commons-cli.version>
Expand Down
Loading