Skip to content

[swift6][client] All models conform to Codable so this method should not be needed anymore#21117

Merged
4brunu merged 3 commits intoOpenAPITools:masterfrom
4brunu:feature/remove-old-encodable-code
Apr 22, 2025
Merged

[swift6][client] All models conform to Codable so this method should not be needed anymore#21117
4brunu merged 3 commits intoOpenAPITools:masterfrom
4brunu:feature/remove-old-encodable-code

Conversation

@4brunu
Copy link
Copy Markdown
Contributor

@4brunu 4brunu commented Apr 22, 2025

All models conform to Codable so this method should not be needed anymore

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@jgavris (2017/07) @ehyche (2017/08) @Edubits (2017/09) @jaz-ah (2017/09) @4brunu (2019/11) @dydus0x14 (2023/06)

@4brunu
Copy link
Copy Markdown
Contributor Author

4brunu commented Apr 22, 2025

CI failure is not related to this PR.

@4brunu 4brunu merged commit 64d9719 into OpenAPITools:master Apr 22, 2025
15 of 16 checks passed
@4brunu 4brunu deleted the feature/remove-old-encodable-code branch April 22, 2025 10:58
@wing328 wing328 added this to the 7.13.0 milestone Apr 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants