[php-symfony] fix handling of endpoints with "text/plain" or "image/png" response type

modules/openapi-generator/src/main/java/org/openapitools/codegen/languages/PhpSymfonyServerCodegen.java

@@ -417,10 +417,16 @@ public OperationsMap postProcessOperationsWithModels(OperationsMap objs, List<Mo
                 op.vendorExtensions.put("x-comment-type", "void");
             }
             // Create a variable to add typing for return value of interface
-            if (op.returnType != null) {
+            if (op.returnType == null) {
+                op.vendorExtensions.put("x-return-type", "void");
+            } else if (op.isArray || op.isMap || isApplicationJsonOrApplicationXml(op)
+                    || !op.returnTypeIsPrimitive // it could make sense to remove it, but it would break retro-compatibility
+            ) {
                 op.vendorExtensions.put("x-return-type", "array|object|null");
+            } else if ("binary".equals(op.returnProperty.dataFormat)) {
+                op.vendorExtensions.put("x-return-type", "mixed");
             } else {
-                op.vendorExtensions.put("x-return-type", "void");
+                op.vendorExtensions.put("x-return-type", op.returnType);
             }
 
             // Add operation's authentication methods to whole interface
@@ -438,6 +444,18 @@ public OperationsMap postProcessOperationsWithModels(OperationsMap objs, List<Mo
         return objs;
     }
 
+    private boolean isApplicationJsonOrApplicationXml(CodegenOperation op) {
+       if (op.produces != null) {
+           for(Map<String, String> produce : op.produces) {
+               String mediaType = produce.get("mediaType");
+               if (isJsonMimeType(mediaType) || isXmlMimeType(mediaType)) {
+                  return true;
+               }
+           }
+       }
+       return false;
+    }
+
     @Override
     public ModelsMap postProcessModels(ModelsMap objs) {
         objs = super.postProcessModels(objs);

modules/openapi-generator/src/main/resources/php-symfony/Controller.mustache

@@ -204,6 +204,10 @@ class Controller extends AbstractController
             return 'application/xml';
         }
 
+        if (in_array('*/*', $accept)) {
+            return $produced[0];
+        }
+
         // If we reach this point, we don't have a common ground between server and client
         return null;
     }

modules/openapi-generator/src/main/resources/php-symfony/serialization/JmsSerializer.mustache

@@ -29,7 +29,13 @@ class JmsSerializer implements SerializerInterface
      */
     public function serialize($data, string $format): string
     {
-        return SerializerBuilder::create()->build()->serialize($data, $this->convertFormat($format));
+        $convertFormat = $this->convertFormat($format);
+        if ($convertFormat !== null) {
+           return SerializerBuilder::create()->build()->serialize($data, $convertFormat);
+        } else {
+           // don't use var_export if $data is already a string: it may corrupt binary strings
+           return is_string($data) ? $data : var_export($data, true);
+        }
     }
 
     /**

samples/server/petstore/php-symfony/SymfonyBundle-php/Controller/Controller.php

@@ -214,6 +214,10 @@ protected function getOutputFormat(string $accept, array $produced): ?string
             return 'application/xml';
         }
 
+        if (in_array('*/*', $accept)) {
+            return $produced[0];
+        }
+
         // If we reach this point, we don't have a common ground between server and client
         return null;
     }

samples/server/petstore/php-symfony/SymfonyBundle-php/Service/JmsSerializer.php

@@ -29,7 +29,13 @@ public function __construct()
      */
     public function serialize($data, string $format): string
     {
-        return SerializerBuilder::create()->build()->serialize($data, $this->convertFormat($format));
+        $convertFormat = $this->convertFormat($format);
+        if ($convertFormat !== null) {
+           return SerializerBuilder::create()->build()->serialize($data, $convertFormat);
+        } else {
+           // don't use var_export if $data is already a string: it may corrupt binary strings
+           return is_string($data) ? $data : var_export($data, true);
+        }
     }
 
     /**