fix: update axum generated multipart requests to own the body#21301
fix: update axum generated multipart requests to own the body#21301wing328 merged 6 commits intoOpenAPITools:masterfrom
Conversation
… Body Notes: &Multipart cannot access fields, as we need mutable access.
|
thanks for the PR please run |
|
@wing328 done, will push. Is there a test that will check that the servers compile and/or successfully produce multipart? |
Notes: Ran ./mvnw clean package || exit ./bin/generate-samples.sh ./bin/configs/*.yaml || exit ./bin/utils/export_docs_generators.sh || exit
Notes: Multipart should be owned; normal request remains borrowed
| @@ -1 +1 @@ | |||
| 7.13.0-SNAPSHOT | |||
| 7.12.0-SNAPSHOT | |||
There was a problem hiding this comment.
can you please merge the latest master (upstream official) to your branch, build the CLI JAR locally and regenerate the samples again?
|
thanks for the PR cc @linxGnu |
|
let's give it a try thanks again for the PR |
|
Sorry for late reply due to urgent project at my full-time job. The PR LGTM. Also fyi @Victoria-Casasampere-BeeTheData about the changes |
|
@wing328 am I missing something, or is this MR merged but not showing up in newer versions? |
|
Seem like there are changes between. Would you mind to make a PR to fix this (or I can make a PR on your behalf)? Latest Commit (in master branch) already included your changes: |
|
In the meantime, you can use this feature flag as well: |
Hey @linxGnu, I'm not sure I understand what the issue is, would you mind raising the PR and tagging me there? Thanks! |
This PR updates axum multipart requests (multipart and multipart-related) to give ownership of the multipart request contents to the application.
The following method on
Multiparthighlights the need:it requires
&muton the multipart argument to allow reading its contents.In axum documentation, multipart requests are implemented with full ownership (https://docs.rs/axum/latest/axum/extract/struct.Multipart.html).
Taken from the above link, please note the order of parameters is important:
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming7.x.0minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)