replace deprecated 'typings' field with standard 'types' in package.json#21371
Merged
macjohnny merged 2 commits intoOpenAPITools:masterfrom Sep 25, 2025
Merged
Conversation
Member
|
please follow step 3 to update the samples |
Contributor
Author
|
@wing328 any idea what's the ci issue ? |
Member
|
cc @TiFu (2017/07) @taxpon (2017/07) @sebastianhaas (2017/07) @kenisteward (2017/07) @Vrolijkx (2017/09) @macjohnny (2018/01) @topce (2018/10) @akehir (2019/07) @petejohansonxo (2019/11) @amakhrov (2020/02) @davidgamero (2022/03) @mkusaka (2022/04) @joscha (2024/10) |
Contributor
I can't seem to open the CircleCI page for some reason - what's the message in there? |
Member
|
me neither - i got "page not found" anyway node 0 tests in circleci is not related to typescript: https://github.com/OpenAPITools/openapi-generator/blob/master/CI/circle_parallel.sh#L116 so it can be ignored for this change |
macjohnny
approved these changes
Sep 25, 2025
Member
|
@kaizencode-art thanks for this contribution! |
rajvesh
pushed a commit
to rajvesh/openapi-generator
that referenced
this pull request
Dec 25, 2025
…son (OpenAPITools#21371) * replace deprecated 'typings' field with standard 'types' in package.json * regenerate samples after replacing 'typings' with 'types' field --------- Co-authored-by: winiga <winiga@rocketmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replaces deprecated
"typings"field with"types"inpackage.json.Without this fix, some IDEs (e.g., VS Code) fail to resolve type definitions correctly when using this package, due to
"typings"being ignored in favor of the standard"types"field.