Make all C# flavors support x-zero-based-enum and add tables to documentation#21463
Merged
wing328 merged 2 commits intoOpenAPITools:masterfrom Aug 12, 2025
Merged
Make all C# flavors support x-zero-based-enum and add tables to documentation#21463wing328 merged 2 commits intoOpenAPITools:masterfrom
x-zero-based-enum and add tables to documentation#21463wing328 merged 2 commits intoOpenAPITools:masterfrom
Conversation
Member
i think that's fixed on the latest master can you please pull the latest changes in the official master into your branch? |
e9b4e91 to
93d44fb
Compare
Contributor
Author
|
Alright so the build works now, that also made me realize where to add the vendor extensions so the docs update correctly. |
Member
|
cc @devhl-labs as well who maintains the C# generichost (default) client generator |
Goopher
pushed a commit
to Goopher/openapi-generator
that referenced
this pull request
Sep 9, 2025
…umentation (OpenAPITools#21463) * Make all C# flavors support x-zero-based-enum and add table to documentation * Add the documentation stuff properly
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes all other C# flavors also support the
x-zero-based-enumvendor extension and it documents it.Arguably the enums should be some tuple with an actual
valuefield so the Java code can have full control, but this will work for now.PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming7.x.0minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)C# Technical Committee
@mandrean @shibayan @Blackclaws @lucamazzanti @iBicha
EDIT: The build works now and everything has been committed.