Dart generator: Add default value for optional params#21502
Closed
djibouleau wants to merge 1 commit intoOpenAPITools:masterfrom
Closed
Dart generator: Add default value for optional params#21502djibouleau wants to merge 1 commit intoOpenAPITools:masterfrom
djibouleau wants to merge 1 commit intoOpenAPITools:masterfrom
Conversation
acb50b2 to
a0b35cc
Compare
6 tasks
Contributor
|
This looks to be generated client code? If that is the case, then I believe it is technically incorrect to submit the default value as a client with a call. See section The default value is the value that the server will use if the client does not send a value for that field. So if the client is fine with the default, then it is best to omit sending a value. If the generated code mirrors the default, then one might misalign with the server if they were to change their default. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the spec mentions a default value for a parameter, it is recorded as an optional param. I updated the template to include the default value. Tested with FastAPI :
Generated code :