Skip to content

DefaultCodegenTest use same test engine for all tests#21532

Merged
wing328 merged 3 commits intoOpenAPITools:masterfrom
Mattias-Sehlstedt:default-codegen-test-cleanup
Jul 10, 2025
Merged

DefaultCodegenTest use same test engine for all tests#21532
wing328 merged 3 commits intoOpenAPITools:masterfrom
Mattias-Sehlstedt:default-codegen-test-cleanup

Conversation

@Mattias-Sehlstedt
Copy link
Copy Markdown
Contributor

@Mattias-Sehlstedt Mattias-Sehlstedt commented Jul 8, 2025

Changes so that the DefaultCodegenTest uses one test engine rather than each test using one of the two present in the project (junit and testng). This removes most warnings in the file that are not tied to a Raw use of parameterized class Schema warning.

These are fixes that I have done as part of an investigation into how to best extend useOneOfInterfaces to generated sealed interfaces. But since that might take a while I thought I might as well merge fixes that can be separated from that functionality.

Includes fix for samples that were not updated with this change.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@wing328
Copy link
Copy Markdown
Member

wing328 commented Jul 10, 2025

tested locally and the result looks good

thanks for the contribution 👍

@wing328 wing328 merged commit c6b51ff into OpenAPITools:master Jul 10, 2025
50 checks passed
@Mattias-Sehlstedt Mattias-Sehlstedt deleted the default-codegen-test-cleanup branch July 10, 2025 09:33
@wing328 wing328 added this to the 7.15.0 milestone Aug 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants