[Typescript] Fix warning logs for additional properties that have not been set#21630
Merged
wing328 merged 2 commits intoOpenAPITools:masterfrom Aug 16, 2025
Merged
Conversation
wing328
reviewed
Jul 26, 2025
| result = Boolean.parseBoolean((String) booleanValue); | ||
| } else { | ||
| LOGGER.warn("The value (generator's option) must be either boolean or string. Default to `false`."); | ||
| LOGGER.warn("The value {} must be either boolean or string. Default to `false`.", propertyKey); |
Member
There was a problem hiding this comment.
thanks for the PR
can we still keep (generator's option) in the log some users misunderstood this option as a global option instead if I remember correctly?
Contributor
Author
There was a problem hiding this comment.
I have readded that information to the log
Mattias-Sehlstedt
force-pushed
the
typescript-additional-properties
branch
from
3ca9220 to
a537002
Compare
6 tasks
Goopher
pushed a commit
to Goopher/openapi-generator
that referenced
this pull request
Sep 9, 2025
… been set (OpenAPITools#21630) * Fix warning logs for additional properties that have not been set * Readd warning log details to clarify what option that the log refers to
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Utilizes the Codegen parsing introduced in #18935 to get rid of warnings for incorrectly set
additionalPropertieswhen they are not set rather than incorrectly set.I.e., the client was getting
The value (generator's option) must be either boolean or string. Default to "false".foruseRxJSwhen generating a client, even though they had not even stated a value for it.PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming7.x.0minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)