Skip to content

Default nested array to null in java generators #21713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wing328 merged 2 commits into from
Aug 8, 2025
Merged

Default nested array to null in java generators #21713

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e9791b3
default nested array to null in java generators
wing328 Aug 7, 2025
33fed2c
add test schema
wing328 Aug 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions ...enapi-generator/src/main/java/org/openapitools/codegen/languages/AbstractJavaCodegen.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1291,6 +1291,9 @@ public String toArrayDefaultValue(CodegenProperty cp, Schema schema) {
}
})
.collect(Collectors.joining(", "));
} else if (cp.items.isContainer) {
// TODO nested array/set/map is not supported at the moment so defaulting to null
defaultValue = null;
} else { // array item is non-string, e.g. integer
defaultValue = StringUtils.join(_values, ", ");
}
Expand Down
17 changes: 17 additions & 0 deletions .../test/resources/3_0/java/petstore-with-fake-endpoints-models-for-testing-okhttp-gson.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2809,3 +2809,20 @@ components:
$ref: '#/components/schemas/ArrayOneOf'
anyof_prop:
$ref: '#/components/schemas/ArrayAnyOf'
NestedArrayWithDefaultValues:
type: object
properties:
nestedArray:
type: array
items:
type: array
items:
type: string
default: ["value1", "value2"]
default:
[
[ "h1", "Header 1" ],
[ "h2", "Header 2" ],
[ "h3", "Header 3" ],
[ "h4", "Header 4" ]
]
2 changes: 2 additions & 0 deletions samples/client/petstore/java/okhttp-gson/.openapi-generator/FILES
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,7 @@ docs/ModelList.md
docs/ModelReturn.md
docs/ModelWithOneOfAnyOfProperties.md
docs/Name.md
docs/NestedArrayWithDefaultValues.md
docs/NewPet.md
docs/NewPetCategoryInlineAllof.md
docs/NewPetCategoryInlineAllofAllOfCategoryTag.md
Expand Down Expand Up @@ -216,6 +217,7 @@ src/main/java/org/openapitools/client/model/ModelList.java
src/main/java/org/openapitools/client/model/ModelReturn.java
src/main/java/org/openapitools/client/model/ModelWithOneOfAnyOfProperties.java
src/main/java/org/openapitools/client/model/Name.java
src/main/java/org/openapitools/client/model/NestedArrayWithDefaultValues.java
src/main/java/org/openapitools/client/model/NewPet.java
src/main/java/org/openapitools/client/model/NewPetCategoryInlineAllof.java
src/main/java/org/openapitools/client/model/NewPetCategoryInlineAllofAllOfCategoryTag.java
Expand Down
1 change: 1 addition & 0 deletions samples/client/petstore/java/okhttp-gson/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,6 +233,7 @@ Class | Method | HTTP request | Description
- [ModelReturn](docs/ModelReturn.md)
- [ModelWithOneOfAnyOfProperties](docs/ModelWithOneOfAnyOfProperties.md)
- [Name](docs/Name.md)
- [NestedArrayWithDefaultValues](docs/NestedArrayWithDefaultValues.md)
- [NewPet](docs/NewPet.md)
- [NewPetCategoryInlineAllof](docs/NewPetCategoryInlineAllof.md)
- [NewPetCategoryInlineAllofAllOfCategoryTag](docs/NewPetCategoryInlineAllofAllOfCategoryTag.md)
Expand Down
21 changes: 21 additions & 0 deletions samples/client/petstore/java/okhttp-gson/api/openapi.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2916,6 +2916,27 @@ components:
anyof_prop:
$ref: "#/components/schemas/ArrayAnyOf"
type: object
NestedArrayWithDefaultValues:
properties:
nestedArray:
default:
- - h1
- Header 1
- - h2
- Header 2
- - h3
- Header 3
- - h4
- Header 4
items:
default:
- value1
- value2
items:
type: string
type: array
type: array
type: object
_foo_get_default_response:
example:
string:
Expand Down
13 changes: 13 additions & 0 deletions samples/client/petstore/java/okhttp-gson/docs/NestedArrayWithDefaultValues.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@


# NestedArrayWithDefaultValues


## Properties

| Name | Type | Description | Notes |
|------------ | ------------- | ------------- | -------------|
|**nestedArray** | **List<List<String>>** | | [optional] |



1 change: 1 addition & 0 deletions samples/client/petstore/java/okhttp-gson/src/main/java/org/openapitools/client/JSON.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -303,6 +303,7 @@ private static Class getClassByDiscriminator(Map classByDiscriminatorValue, Stri
gsonBuilder.registerTypeAdapterFactory(new org.openapitools.client.model.ModelReturn.CustomTypeAdapterFactory());
gsonBuilder.registerTypeAdapterFactory(new org.openapitools.client.model.ModelWithOneOfAnyOfProperties.CustomTypeAdapterFactory());
gsonBuilder.registerTypeAdapterFactory(new org.openapitools.client.model.Name.CustomTypeAdapterFactory());
gsonBuilder.registerTypeAdapterFactory(new org.openapitools.client.model.NestedArrayWithDefaultValues.CustomTypeAdapterFactory());
gsonBuilder.registerTypeAdapterFactory(new org.openapitools.client.model.NewPet.CustomTypeAdapterFactory());
gsonBuilder.registerTypeAdapterFactory(new org.openapitools.client.model.NewPetCategoryInlineAllof.CustomTypeAdapterFactory());
gsonBuilder.registerTypeAdapterFactory(new org.openapitools.client.model.NewPetCategoryInlineAllofAllOfCategoryTag.CustomTypeAdapterFactory());
Expand Down
Loading
Loading