Skip to content

Fix rust-axum homepage toml quotes#21716

Merged
wing328 merged 1 commit intoOpenAPITools:masterfrom
andrzejressel:rust_axum_close_toml_homepage
Aug 8, 2025
Merged

Fix rust-axum homepage toml quotes#21716
wing328 merged 1 commit intoOpenAPITools:masterfrom
andrzejressel:rust_axum_close_toml_homepage

Conversation

@andrzejressel
Copy link
Copy Markdown
Contributor

@andrzejressel andrzejressel commented Aug 7, 2025

The homepage quote on rust-axum's Cargo.toml wasn't closed

@frol @farcaller @richardwhiuk @paladinzh @jacob-pro @dsteeley

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR solves a reported issue, reference it using GitHub's linking syntax (e.g., having "fixes #123" present in the PR description)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Copilot AI review requested due to automatic review settings August 7, 2025 22:11
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request optimizes HTTP header creation in Rust code by replacing HeaderValue::from_str() with HeaderValue::from_static() for static string literals, and includes various code quality improvements such as fixing semicolons, reorganizing imports, and adding missing homepage metadata to Cargo.toml files.

Key changes:

  • Replaced error-prone HeaderValue::from_str() calls with more efficient HeaderValue::from_static() for static content types
  • Fixed import ordering and semicolon placement throughout Rust codebases
  • Added homepage field to multiple Cargo.toml files to improve package metadata

Reviewed Changes

Copilot reviewed 68 out of 81 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
samples/server/petstore/rust-server/output/*/src/server/mod.rs Optimized header value creation for static content types
samples/server/petstore/rust-server/output/*/src/client/mod.rs Replaced HeaderValue::from_str with from_static for content type headers
samples/server/petstore/rust-axum/output/*/src/server/mod.rs Applied header optimization and import organization
samples/server/petstore/rust-axum/output/*/src/models.rs Fixed semicolon placement and code formatting
samples/server/petstore/rust-axum/output/*/Cargo.toml Added homepage metadata field
samples/server/petstore/rust-axum/output/*/src/types.rs Reorganized imports for better consistency

@@ -1,9 +1,10 @@
[package]
name = "rust-axum-header-uui"
name = "rust-axum-header-uuid"
Copy link

Copilot AI Aug 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The package name was corrected from 'rust-axum-header-uui' to 'rust-axum-header-uuid' to fix the typo in 'uuid'.

Copilot uses AI. Check for mistakes.
@andrzejressel andrzejressel force-pushed the rust_axum_close_toml_homepage branch from a302ed9 to 83e5391 Compare August 7, 2025 22:11
@wing328 wing328 merged commit 0f231d9 into OpenAPITools:master Aug 8, 2025
20 checks passed
@wing328
Copy link
Copy Markdown
Member

wing328 commented Aug 8, 2025

thanks for the fix, which looks good to me

@wing328 wing328 added this to the 7.15.0 milestone Aug 8, 2025
Goopher pushed a commit to Goopher/openapi-generator that referenced this pull request Sep 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants