Fix rust-axum homepage toml quotes#21716
Merged
wing328 merged 1 commit intoOpenAPITools:masterfrom Aug 8, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request optimizes HTTP header creation in Rust code by replacing HeaderValue::from_str() with HeaderValue::from_static() for static string literals, and includes various code quality improvements such as fixing semicolons, reorganizing imports, and adding missing homepage metadata to Cargo.toml files.
Key changes:
- Replaced error-prone
HeaderValue::from_str()calls with more efficientHeaderValue::from_static()for static content types - Fixed import ordering and semicolon placement throughout Rust codebases
- Added homepage field to multiple Cargo.toml files to improve package metadata
Reviewed Changes
Copilot reviewed 68 out of 81 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| samples/server/petstore/rust-server/output/*/src/server/mod.rs | Optimized header value creation for static content types |
| samples/server/petstore/rust-server/output/*/src/client/mod.rs | Replaced HeaderValue::from_str with from_static for content type headers |
| samples/server/petstore/rust-axum/output/*/src/server/mod.rs | Applied header optimization and import organization |
| samples/server/petstore/rust-axum/output/*/src/models.rs | Fixed semicolon placement and code formatting |
| samples/server/petstore/rust-axum/output/*/Cargo.toml | Added homepage metadata field |
| samples/server/petstore/rust-axum/output/*/src/types.rs | Reorganized imports for better consistency |
| @@ -1,9 +1,10 @@ | |||
| [package] | |||
| name = "rust-axum-header-uui" | |||
| name = "rust-axum-header-uuid" | |||
There was a problem hiding this comment.
The package name was corrected from 'rust-axum-header-uui' to 'rust-axum-header-uuid' to fix the typo in 'uuid'.
a302ed9 to
83e5391
Compare
Member
|
thanks for the fix, which looks good to me |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
homepagequote on rust-axum's Cargo.toml wasn't closed@frol @farcaller @richardwhiuk @paladinzh @jacob-pro @dsteeley
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming7.x.0minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)"fixes #123"present in the PR description)