Use Python uuid.UUID instead of StrictStr#21740
Merged
wing328 merged 1 commit intoOpenAPITools:masterfrom Aug 17, 2025
RagnaRockGeo:python_uuid_support
Merged
Use Python uuid.UUID instead of StrictStr#21740wing328 merged 1 commit intoOpenAPITools:masterfrom RagnaRockGeo:python_uuid_support
wing328 merged 1 commit intoOpenAPITools:masterfrom
RagnaRockGeo:python_uuid_support
Conversation
Member
|
@EspenHa thanks for the PR what about targeting current master by considering this as a bug fix instead? if later users need strings to represent uuid (for backward compatibility), we will add an option for fallback. |
Contributor
Author
|
@wing328 Sure, I updated it to target master now |
Member
did you test the fix locally to confirm it works for your use cases? |
Contributor
Author
|
Yes, I'm using a generated client library based on this PR now, as far as I can tell it works without any issues. |
Member
|
Good. Let's give it a try Thanks for the contribution. |
Goopher
pushed a commit
to Goopher/openapi-generator
that referenced
this pull request
Sep 9, 2025
This was referenced Nov 7, 2025
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR will change the Python type hint for uuid fields from
StrictStrtouuid.UUID.Solves #19485.
I essentially just copied the changes suggested by @to-bee in this comment: #19485 (comment) .
Since this will be a breaking change, should it be hidden behind some flag or option? I opened the pull request against the 8.0.x branch, please change this if it is wrong.
@cbornet @tomplus @krjakbrjak @fa0311 @multani
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming7.x.0minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)"fixes #123"present in the PR description)