[typscript] change @export to @exports#21754
Open
jckr wants to merge 2 commits intoOpenAPITools:masterfrom
Open
[typscript] change @export to @exports#21754jckr wants to merge 2 commits intoOpenAPITools:masterfrom
jckr wants to merge 2 commits intoOpenAPITools:masterfrom
Conversation
6 tasks
macjohnny
approved these changes
Aug 15, 2025
Member
|
thanks! |
Member
|
@jckr please re-generate the samples (see PR description) |
davidgamero
approved these changes
Aug 15, 2025
Contributor
|
im debugging the same windows test failure too (unrelated to the samples afaict) the grade |
Author
|
@macjohnny I have added a commit for the samples |
Member
|
@jckr can you merge the most recent master? maybe that resolves the CI issues |
Member
|
FYI this is superseded by #21776 |
6 tasks
Member
|
closing this in favor of #21776 |
Member
|
oops, #21776 was for typescript-axios, while this one is for typescript, so reopened and waiting for merging in the latest master branch |
Member
|
but it raises an interesting question: should the jsdoc be removed altogether, since the information is already present in typescript? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
one of the typescript templates uses a
@exporttag which is incorrect - the right form is@exports(see https://jsdoc.app/tags-exports). As a result, the generated code may trigger linters.This PR corrects the syntax.
fixes #21753
@TiFu @taxpon @sebastianhaas @kenisteward @Vrolijkx @macjohnny @topce @akehir @petejohansonxo @amakhrov @davidgamero @mkusaka @joscha
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming7.x.0minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)"fixes #123"present in the PR description)