Skip to content

Add TrimLineBreaks, TrimWhitespace and TrimTrailing lambdas to DefaultCodegen#21759

Merged
wing328 merged 1 commit intoOpenAPITools:masterfrom
pimmerks:master
Aug 16, 2025
Merged

Add TrimLineBreaks, TrimWhitespace and TrimTrailing lambdas to DefaultCodegen#21759
wing328 merged 1 commit intoOpenAPITools:masterfrom
pimmerks:master

Conversation

@pimmerks
Copy link
Copy Markdown
Contributor

We are currently in a situation with our custom templates where we are running into quite long lines with multiple if/else mustache statements.
We would like to chop up those lines, but that messes with our language's syntax (go).

With this change I would like to introduce these lambda's into the Codegen templates:

  • trimLineBreaks
  • trimWhitespace
  • trimTrailingWithNewLine
  • trimTrailing

As the C# codegen already uses some of these, I've removed them from there.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR solves a reported issue, reference it using GitHub's linking syntax (e.g., having "fixes #123" present in the PR description)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@wing328
Copy link
Copy Markdown
Member

wing328 commented Aug 16, 2025

windows ci failure fixed in #21761

@wing328 wing328 merged commit 9cd04e7 into OpenAPITools:master Aug 16, 2025
12 of 14 checks passed
@wing328 wing328 added this to the 7.15.0 milestone Aug 22, 2025
Goopher pushed a commit to Goopher/openapi-generator that referenced this pull request Sep 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants