Skip to content

[jaxsrs-spec] Support additional properties with composed schema#21914

Open
jaxsonp18-spec wants to merge 5 commits intoOpenAPITools:masterfrom
jaxsonp18-spec:issue-21584
Open

[jaxsrs-spec] Support additional properties with composed schema#21914
jaxsonp18-spec wants to merge 5 commits intoOpenAPITools:masterfrom
jaxsonp18-spec:issue-21584

Conversation

@jaxsonp18-spec
Copy link
Copy Markdown

Fixes #21584

When additionalProperties is set to true, use an additionalProperties attribute and @JsonAnySetter and @JsonAnyGetter annotations instead of extending HashMap.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR solves a reported issue, reference it using GitHub's linking syntax (e.g., having "fixes #123" present in the PR description)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10) @martin-mfg (2023/08)

@wing328
Copy link
Copy Markdown
Member

wing328 commented Oct 21, 2025

thanks for the pr

did you have a chance to review https://github.com/OpenAPITools/openapi-generator/actions/runs/17516954009/job/49755989849?pr=21914 ?

@jaxsonp18-spec
Copy link
Copy Markdown
Author

jaxsonp18-spec commented Oct 27, 2025

@wing328 sorry for the late response.

Yes, I did look into the failed build. It looks like the build failed due to a failed test org.openapitools.codegen.config.GlobalSettingsTest.testNonStringSystemProperties, but looking here the test is apparently inconsistent and should be disabled.

Looks like the test passed this time around, though

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] [JAX-RS] can't combine properties and additionalProperties in a schema

3 participants