Skip to content

[typescript-axios][typescript-fetch] Generated code compiles with the "exactOptionalPropertyTypes" option#22187

Open
adam-earthscope wants to merge 11 commits intoOpenAPITools:masterfrom
adam-earthscope:master
Open

[typescript-axios][typescript-fetch] Generated code compiles with the "exactOptionalPropertyTypes" option#22187
adam-earthscope wants to merge 11 commits intoOpenAPITools:masterfrom
adam-earthscope:master

Conversation

@adam-earthscope
Copy link
Copy Markdown

Fixes #22153 and #14793

This adds undefined as a potential value to all optional attributes in the generated code.

@TiFu (2017/07) @taxpon (2017/07) @sebastianhaas (2017/07) @kenisteward (2017/07) @Vrolijkx (2017/09) @macjohnny (2018/01) @topce (2018/10) @akehir (2019/07) @petejohansonxo (2019/11) @amakhrov (2020/02) @davidgamero (2022/03) @mkusaka (2022/04) @joscha (2024/10)

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR solves a reported issue, reference it using GitHub's linking syntax (e.g., having "fixes #123" present in the PR description)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@adam-earthscope adam-earthscope changed the title fix: Produce typescript-axios and typescript-fetch code that compiles with the "exactOptionalPropertyTypes" option. [typescript-axios][typescript-fetch] Generated code compiles with the "exactOptionalPropertyTypes" option Oct 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] [typescipt-axios] Generated code fails with "exactOptionalPropertyTypes" compiler option

2 participants