[rust-axum] Fix polymorphic type discriminators#22222
Merged
wing328 merged 4 commits intoOpenAPITools:masterfrom Oct 25, 2025
Merged
[rust-axum] Fix polymorphic type discriminators#22222wing328 merged 4 commits intoOpenAPITools:masterfrom
wing328 merged 4 commits intoOpenAPITools:masterfrom
Conversation
linxGnu
approved these changes
Oct 25, 2025
Contributor
linxGnu
left a comment
There was a problem hiding this comment.
LGTM. Thank you for making the fix
Contributor
|
Test failing because: Could you please update this line with new checksum: |
Contributor
Author
|
@linxGnu updated. Thanks for the quick review! |
Contributor
|
@wing328 PTAL. I think it's good to merge |
rajvesh
pushed a commit
to rajvesh/openapi-generator
that referenced
this pull request
Dec 25, 2025
* [rust-axum] Make discriminator field name camelCase * [rust-axum] Give polymorphic enum values a serde alias using the mapping keys if available * update samples * update test file checksum
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR attempts to address 2 issues I am having with the rust-axum code generation for polymorphic types:
renameattribute with the camelCase version of the attribute name. This is inconsistent with other generated fields.Please review updates to tests and samples for examples of my use cases.
cc @linxGnu
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming7.x.0minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)"fixes #123"present in the PR description)